Move optional workspaces TEP to implementable #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional workspaces TEP was pretty thoroughly edited and reviewed during the proposal phase (#169). There were no outstanding blockers or requests for more information that I'm aware of that should prevent this TEP moving to implementable. This PR moves the optional workspaces TEP into implementable state with intention to go ahead and add this feature to Tekton Pipelines.
tekton-robot
added
the
size/XS
|
I'm happy to go ahead! Wouldn't mind hearing from a couple more @tektoncd/core-maintainers folks before we merge if possible /lgtm |
|
/lgtm |
|
Per our TEP instructions we have approvals from owners from at least two companies. seems ready to merge? would someone mind giving the approve flag? |
ghost
mentioned this pull request
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional workspaces TEP was pretty thoroughly edited and reviewed
during the proposal phase (#169).
There were no outstanding blockers or requests for more information that
I'm aware of that should prevent this TEP moving to implementable.
This PR moves the optional workspaces TEP into implementable state with
intention to go ahead and add this feature to Tekton Pipelines.