TEP-0061 Allow custom task to be embedded in pipeline, design.

[ScrapCodes]

Thank you, @Tomcli, @pritidesai, @sbwsg, @imjasonh, @bobcatfish, @afrittoli and @vdemeester for taking a look !

[Tomcli]

lgtm

[pritidesai]

I would recommend to have it split in two PRs rather than three. (1) Add documentation with a preview mode (2) Code changes + testing

At the same time, it's great to have it but does not have to be part of the TEP.

[ScrapCodes]

This sounds good to me !

[pritidesai]

I do not understand this non-goal here. Please explain a little more.

Also, we already have support for metadata while embedding the task specifications which must be propagated to Run or TaskRun:

type EmbeddedTask struct {
	// +optional
	Metadata PipelineTaskMetadata `json:"metadata,omitempty"`

	// TaskSpec is a specification of a task
	TaskSpec `json:",inline,omitempty"`
}

[ScrapCodes]

Thank you for the question, @pritidesai. I am sorry, metadata is supported but it is limited to the sub-fields Labels and annotations

type PipelineTaskMetadata struct {
	// +optional
	Labels map[string]string `json:"labels,omitempty"`

	// +optional
	Annotations map[string]string `json:"annotations,omitempty"`
}

In the normal creation of a custom task resource object, e.g.:

apiVersion: custom.tekton.dev/v1alpha1
kind: TaskLoop
metadata:  # A metadata field e.g. name is supported 
  name: simpletaskloop
spec:
  taskRef:
    name: simpletask
  iterateParam: word
  timeout: 60s
  retries: 2

Once we embed a custom task, specifying it's name becomes irrelevant. But, still is it worth noting that we do not support all the metadata subfields?

I can update the non goal with above clarification, or completely remove it if it leads to confusion by stating the obvious.

[bobcatfish]

/assign @pritidesai
/assign @sbwsg

[ScrapCodes]

Hi @pritidesai and @sbwsg , I have done a self pass and removed those items that seemed like stating the obvious. Please take a look.

There is an opened PR with implementation, tektoncd/pipeline#3901 .

Thank you, for helping this work move forward.

[ghost]

Great addition, thank you.

[ghost]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• teps/OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pritidesai]

thanks @ScrapCodes @Tomcli for the patience, sorry missed to review it. Looks great and exciting to have this feature.

/lgtm

[ScrapCodes]

Thanks a lot, @pritidesai, @sbwsg and @Tomcli.