Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0079: Tekton Catalog Support Tiers [Proposal - Ownership and Maintenance] #599

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jan 7, 2022

In TEP-0079: Tekton Catalog Support Tiers, we have defined
the problem statement for establishing support tiers for resources in
the Tekton Catalog.

In this change, we address the first goal of Ownership and Maintenance.

As previously discussed in TEP-0003, we propose creating
two support tiers, Community and Official, through separate Tekton Catalogs.

The Community Catalog would make it easy for contributors to share resources,
while the Official Catalog will be a corpus of high quality resources that
users can rely on. This distribution of ownership would ensure the workload
is sustainable.

The other goals and details of testing, scanning and verification will be
explored in the subsequent changes.

/kind tep
/cc @bobcatfish @vdemeester @vinamra28 @tektoncd/catalog-maintainers

@tekton-robot tekton-robot added kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2022
@jerop jerop force-pushed the support-tiers-proposal branch 2 times, most recently from 84111d0 to 6a81b88 Compare January 8, 2022 17:07
@jerop
Copy link
Member Author

jerop commented Jan 10, 2022

/assign @afrittoli
/assign @vdemeester
/assign @bobcatfish

@lbernick
Copy link
Member

/assign

@jerop jerop force-pushed the support-tiers-proposal branch 3 times, most recently from 1638d8e to 6d1624d Compare January 11, 2022 21:22
@lbernick
Copy link
Member

thanks @jerop, I feel my feedback has been addressed

/approve

@jerop jerop force-pushed the support-tiers-proposal branch 6 times, most recently from 33a5b09 to da73c49 Compare January 13, 2022 13:48
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a very good start 👍🏼

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
teps/0079-tekton-catalog-support-tiers.md Outdated Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Outdated Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
Copy link
Contributor

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the proposal overall! (And no strong feelings from me whether 1 repo or 2, I slightly prefer 2 repos b/c i think it makes it very clear what the tekton catalog owners are expected to maintain - and makes it easier for them to filter issues but can be okay with 1 repo also)

my main piece of feedback (and this might be me reading too much into the wording) is that it feels like this suggests that promotion from community to official is both a goal for community catalog items and also something that would happen frequently. i think that would be very difficult to sustain and suggest that we instead make it very appealing to contribute community items that stay community items, owned by the community members that submit them - i.e. these are not "less than" the official items, they just have different ownership (and maybe this ties into @afrittoli 's preference for 1 repo vs 2)

teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Outdated Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Outdated Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Outdated Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
@vdemeester
Copy link
Member

my main piece of feedback (and this might be me reading too much into the wording) is that it feels like this suggests that promotion from community to official is both a goal for community catalog items and also something that would happen frequently. i think that would be very difficult to sustain and suggest that we instead make it very appealing to contribute community items that stay community items, owned by the community members that submit them - i.e. these are not "less than" the official items, they just have different ownership (and maybe this ties into @afrittoli 's preference for 1 repo vs 2)

I agree with this, and I would do the parallel with the Docker Hub. The set of official image is relatively small compared to what is stored in the Hub. The set of images supported there is driven by bandwidth and will of the team that maintains it and "usefulness" of them (aka images of things that are often used such as known linux distros, DBMS, …). We should aim for the same kind of thing here. There should be way more items in the community catalog than in the official one.

@jerop jerop force-pushed the support-tiers-proposal branch 2 times, most recently from 31ffb49 to e614074 Compare January 25, 2022 04:06
@jerop
Copy link
Member Author

jerop commented Jan 25, 2022

@afrittoli @bobcatfish @sbwsg @vdemeester thank you for the reviews! clarified the tep and incorporated the suggestions into the proposal. please take another look when you have a chance :)

/cc @vinamra28

@jerop jerop force-pushed the support-tiers-proposal branch from e614074 to 0c2b780 Compare January 25, 2022 13:50
Copy link
Contributor

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great to me!! Thanks for all the hard work and back and forth!

/approve

teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop jerop force-pushed the support-tiers-proposal branch from 0c2b780 to 4ba26ad Compare January 26, 2022 01:38
Copy link
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies not being involved earlier but i have added a few comments,

thanks for the effort, i think that would make things much better for our users to have a curated set of official tasks in a repo.

teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
teps/0079-tekton-catalog-support-tiers.md Show resolved Hide resolved
…tenance]

In [TEP-0079: Tekton Catalog Support Tiers][tep-0079], we have defined
the problem statement for establishing support tiers for resources in
the Tekton Catalog.

In this change, we address the first goal of [Ownership and Maintenance][goal].

As previously discussed in [TEP-0003][tep-0003-upstream], we propose creating
two support tiers, `Community` and `Official`, through separate Tekton Catalogs.

The Community Catalog would make it easy for contributors to share resources,
while the Official Catalog will be a corpus of high quality resources that
users can rely on. This distribution of ownership would ensure the workload
is sustainable.

The other goals and details of testing, scanning and verification will be
explored in the subsequent changes.

[tep-0079]: https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md
[goal]: https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#ownership-and-maintenance
[tep-0003-upstream]: https://github.com/tektoncd/community/blob/main/teps/0003-tekton-catalog-organization.md#upstream-catalogs
@jerop jerop force-pushed the support-tiers-proposal branch from 4ba26ad to 4c26b21 Compare January 26, 2022 16:02
Copy link
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks for addressing my comments!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
@tekton-robot tekton-robot merged commit a39bdf8 into tektoncd:main Jan 26, 2022
@afrittoli
Copy link
Member

Thanks for the updates @jerop - it looks good!

@jerop
Copy link
Member Author

jerop commented Jan 26, 2022

Thanks for the reviews @vdemeester @chmouel @bobcatfish @afrittoli @lbernick 🙏🏾

There's an extra small follow up pull request in #613, please take a look when you have a chance

@jerop jerop deleted the support-tiers-proposal branch January 29, 2022 19:18
jerop added a commit to jerop/community that referenced this pull request Aug 22, 2022
In tektoncd#599, we added the
proposal for "Ownership and Maintenance" in [TEP-0079][tep-0079].

Since then, there have been significant changes to the Catalog:
- [TEP-0110][tep-0110]: Decouple Tekton Catalog Organization
from Resource Reference
- [TEP-0115][tep-0115]: Tekton Catalog Git-Based Versioning

In this change, we update [TEP-0079][tep-0079] to align with
[TEP-0110][tep-0110] and [TEP-0115][tep-0115].

/kind tep

[tep-0079]: https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md
[tep-0110]: https://github.com/tektoncd/community/blob/main/teps/0110-decouple-catalog-organization-and-reference.md
[tep-0115]: https://github.com/tektoncd/community/blob/main/teps/0115-tekton-catalog-git-based-versioning.md
jerop added a commit to jerop/community that referenced this pull request Aug 22, 2022
In tektoncd#599, we added the
proposal for "Ownership and Maintenance" in [TEP-0079][tep-0079].

Since then, there have been significant changes to the Catalog:
- [TEP-0110][tep-0110]: Decouple Tekton Catalog Organization
from Resource Reference
- [TEP-0115][tep-0115]: Tekton Catalog Git-Based Versioning

In this change, we update [TEP-0079][tep-0079] to align with
[TEP-0110][tep-0110] and [TEP-0115][tep-0115].

/kind tep

[tep-0079]: https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md
[tep-0110]: https://github.com/tektoncd/community/blob/main/teps/0110-decouple-catalog-organization-and-reference.md
[tep-0115]: https://github.com/tektoncd/community/blob/main/teps/0115-tekton-catalog-git-based-versioning.md
jerop added a commit to jerop/community that referenced this pull request Aug 23, 2022
In tektoncd#599, we added the
proposal for "Ownership and Maintenance" in [TEP-0079][tep-0079].

Since then, there have been significant changes to the Catalog:
- [TEP-0110][tep-0110]: Decouple Tekton Catalog Organization
from Resource Reference
- [TEP-0115][tep-0115]: Tekton Catalog Git-Based Versioning

In this change, we update [TEP-0079][tep-0079] to align with
[TEP-0110][tep-0110] and [TEP-0115][tep-0115].

/kind tep

[tep-0079]: https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md
[tep-0110]: https://github.com/tektoncd/community/blob/main/teps/0110-decouple-catalog-organization-and-reference.md
[tep-0115]: https://github.com/tektoncd/community/blob/main/teps/0115-tekton-catalog-git-based-versioning.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants