Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0104]: Descope to runtime only #722

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[TEP-0104]: Descope to runtime only #722

merged 1 commit into from
Jun 17, 2022

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Jun 9, 2022

This commit updates TEP-0104 to specify that we will implement
Task-level resource requirements for TaskRuns only to start,
and we may consider adding support on Tasks in the future.

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Jun 9, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2022
@lbernick
Copy link
Member Author

lbernick commented Jun 9, 2022

@dibyom @jerop @vdemeester @leeonlee @austinzhao-go PTAL

@austinzhao-go austinzhao-go mentioned this pull request Jun 10, 2022
Merged
11 tasks
@lbernick lbernick force-pushed the tep-0104 branch 2 times, most recently from cec3244 to cc65577 Compare June 10, 2022 19:42
@lbernick
Copy link
Member Author

/assign @jerop @afrittoli

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
austinzhao-go
austinzhao-go reviewed Jun 15, 2022
View reviewed changes
teps/0104-tasklevel-resource-requirements.md
@@ -125,17 +122,17 @@ spec:

This field should also be added to [PipelineRun.TaskRunSpecs][taskRunSpecs].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we still need this field under PipelineRun right?

there is no "legacy" Resources field, but will keep using ComputeResources for a consistent naming

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it still makes sense to have this in PipelineRun.Spec.TaskRunSpecs under "computeResources"

@lbernick
[TEP-0104]: Descope to runtime only
70893c5 
This commit updates TEP-0104 to specify that we will implement
Task-level resource requirements for TaskRuns only to start,
and we may consider adding support on Tasks in the future.
afrittoli
afrittoli reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Lee!
/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop
Copy link
Member

jerop commented Jun 17, 2022

/lgtm

approved by both assignees - @afrittoli and @jerop - so merging offline

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@tekton-robot tekton-robot merged commit 592bdc7 into tektoncd:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@austinzhao-go austinzhao-go austinzhao-go requested changes

@jerop jerop jerop approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@skaegi skaegi Awaiting requested review from skaegi

Assignees

@afrittoli afrittoli

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
TEP Steward Assignments
Status: UnAssigned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbernick @tekton-robot @jerop @afrittoli @austinzhao-go