Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce customized scheduler to resolve issues from tekton #664

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

vincent-pli
Copy link
Member

It's a customized scheduler try to resolve parallel tasks depends on same volume but maybe run on different nodes.

This is a draft version, try to introduce Scheduler framework to handle the issue, for now we adopt affinity assistant but has issue to measure total resource requirements.

Details please check issue: tektoncd/pipeline#3052

I think we will enhance it soon based on further discussion, thanks.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 30, 2020
@vincent-pli
Copy link
Member Author

/assign @imjasonh

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some code style changes I'd like to make (not use klog, take advantage of some helpers from knative/pkg) but I won't block this PR.

Can you also add an OWNERS for this directory so you can lgtm future changes? Probably @jlpettersson too?

scheduler/Makefile Outdated Show resolved Hide resolved
scheduler/README.md Outdated Show resolved Hide resolved
scheduler/pkg/coscheduler/coscheduler.go Outdated Show resolved Hide resolved
…same volume but maybe run on different nodes.

This is a draft version, try to introduce `Scheduler framework` to handle the issue, for now we adopt `affinity assistant` but has issue to measure total resource requirements.

Details please check issue: tektoncd/pipeline#3052

I think we will enhance it soon based on further discussion, thanks.
@vincent-pli
Copy link
Member Author

@imjasonh could you take a look, thanks

@imjasonh
Copy link
Member

imjasonh commented Nov 4, 2020

/lgtm

Let's get this merged and talk about next steps. 👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@vincent-pli
Copy link
Member Author

@abayer @kimsterv
Please take a look, thanks

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@tekton-robot tekton-robot merged commit 1ebafcb into tektoncd:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants