[pipeline-to-taskrun] Get ready to run presubmit tests 🏁 #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tektoncd#770 I tried to add the custom task and OWNERS file - with @jerop's help I realized it would be easier to add the OWNERS file first so that OWNERS can review the custom task itself - but even after that I was still changing a file in the top level test dir to add the custom task to the list of tests kicked off which needs top level OWNERS approval - so this commit is doing that separately. Looking at the script it should be safe to add a directory that doesn't exist because it should just get ignored
tekton-robot
added
the
size/XS
|
/lgtm |
vdemeester
approved these changes
Sep 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In #770 I tried to add the custom task and OWNERS file - with @jerop's
help I realized it would be easier to add the OWNERS file first so that
OWNERS can review the custom task itself - but even after that I was
still changing a file in the top level test dir to add the custom task
to the list of tests kicked off which needs top level OWNERS approval -
so this commit is doing that separately. Looking at the script it should
be safe to add a directory that doesn't exist because it should just get
ignored
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.