[Cherry-pick] Update bundlegeneration mechanism #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
nikhil-thomas
force-pushed
the
bundlegen/fix
branch
2 times, most recently
from
3ea9a05
to
c416811
Compare
Add separate overlays for defalut usecases (development, github release...) and operatorhub bundle generation. e The reason for the change is that operatorhub bundle generation does not need servicce_account.yaml in a separate file. The service account is spcified in CSV file. Signed-off-by: Nikhil Thomas <nikthoma@redhat.com> Update sample operahub bundles Generate sample bundles for Kubernetes and OpenShift Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
bundlegen/fix
branch
from
c416811
to
7794d60
Compare
vdemeester
approved these changes
Oct 28, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify kustomization.yaml in config/
Add separate overlays for defalut usecases (development, github release...) and
operatorhub bundle generation.
The reason for the change is that operatorhub bundle generation does not
need servicce_account.yaml in a separate file. The service account is
spcified in CSV file.
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
(cherry picked from commit 1015c7c)
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes