Issue-6823 Conversion Webhook panic fix

Prior to this, the conversion of task spec from v1beta1 was panicing when the step template was nil since it could not access the underlying deprecated fields. This PR fixes that bug. Related issue: #6823
tektoncd · Jun 13, 2023 · 644f8bc · 644f8bc
1 parent 723c263
commit 644f8bc
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/pkg/apis/pipeline/v1beta1/task_conversion.go b/pkg/apis/pipeline/v1beta1/task_conversion.go
@@ -293,18 +293,21 @@ func retrieveTaskDeprecation(spec *TaskSpec) *taskDeprecation {
 			DeprecatedTTY:                      s.DeprecatedTTY,
 		})
 	}
-	dst := &StepTemplate{
-		DeprecatedName:                     spec.StepTemplate.DeprecatedName,
-		DeprecatedPorts:                    spec.StepTemplate.DeprecatedPorts,
-		DeprecatedLivenessProbe:            spec.StepTemplate.DeprecatedLivenessProbe,
-		DeprecatedReadinessProbe:           spec.StepTemplate.DeprecatedReadinessProbe,
-		DeprecatedStartupProbe:             spec.StepTemplate.DeprecatedStartupProbe,
-		DeprecatedLifecycle:                spec.StepTemplate.DeprecatedLifecycle,
-		DeprecatedTerminationMessagePath:   spec.StepTemplate.DeprecatedTerminationMessagePath,
-		DeprecatedTerminationMessagePolicy: spec.StepTemplate.DeprecatedTerminationMessagePolicy,
-		DeprecatedStdin:                    spec.StepTemplate.DeprecatedStdin,
-		DeprecatedStdinOnce:                spec.StepTemplate.DeprecatedStdinOnce,
-		DeprecatedTTY:                      spec.StepTemplate.DeprecatedTTY,
+	dst := &StepTemplate{}
+	if spec.StepTemplate != nil {
+		dst = &StepTemplate{
+			DeprecatedName:                     spec.StepTemplate.DeprecatedName,
+			DeprecatedPorts:                    spec.StepTemplate.DeprecatedPorts,
+			DeprecatedLivenessProbe:            spec.StepTemplate.DeprecatedLivenessProbe,
+			DeprecatedReadinessProbe:           spec.StepTemplate.DeprecatedReadinessProbe,
+			DeprecatedStartupProbe:             spec.StepTemplate.DeprecatedStartupProbe,
+			DeprecatedLifecycle:                spec.StepTemplate.DeprecatedLifecycle,
+			DeprecatedTerminationMessagePath:   spec.StepTemplate.DeprecatedTerminationMessagePath,
+			DeprecatedTerminationMessagePolicy: spec.StepTemplate.DeprecatedTerminationMessagePolicy,
+			DeprecatedStdin:                    spec.StepTemplate.DeprecatedStdin,
+			DeprecatedStdinOnce:                spec.StepTemplate.DeprecatedStdinOnce,
+			DeprecatedTTY:                      spec.StepTemplate.DeprecatedTTY,
+		}
 	}
 	if reflect.DeepEqual(dst, &StepTemplate{}) {
 		dst = nil