Skip to content

Commit

Permalink
Merge branch 'main' of https://github.com/tektoncd/pipeline into herm…
Browse files Browse the repository at this point in the history
…etic
  • Loading branch information
Priya Wadhwa committed May 18, 2021
2 parents 14828b8 + 567dce3 commit a7219ea
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
4 changes: 2 additions & 2 deletions docs/pipelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ A `Pipeline` definition supports the following fields:
`Pipeline` object. For example, a `name`.
- [`spec`][kubernetes-overview] - Specifies the configuration information for
this `Pipeline` object. This must include:
- [`tasks`](#adding-tasks-to-the-pipeline) - Specifies the `Tasks` that comprise the `Pipeline`
and the details of their execution.
- [`tasks`](#adding-tasks-to-the-pipeline) - Specifies the `Tasks` that comprise the `Pipeline`
and the details of their execution.
- Optional:
- [`resources`](#specifying-resources) - **alpha only** Specifies
[`PipelineResources`](resources.md) needed or created by the `Tasks` comprising the `Pipeline`.
Expand Down
6 changes: 4 additions & 2 deletions pkg/pod/pod_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1235,7 +1235,8 @@ script-heredoc-randomly-generated-78c5n
Volumes: append(implicitVolumes, toolsVolume, downwardVolume),
},
}, {
desc: "hermetic env var",
desc: "hermetic env var",
featureFlags: map[string]string{"enable-api-fields": "alpha"},
ts: v1beta1.TaskSpec{
Steps: []v1beta1.Step{{Container: corev1.Container{
Name: "name",
Expand Down Expand Up @@ -1281,7 +1282,8 @@ script-heredoc-randomly-generated-78c5n
}),
},
}, {
desc: "override hermetic env var",
desc: "override hermetic env var",
featureFlags: map[string]string{"enable-api-fields": "alpha"},
ts: v1beta1.TaskSpec{
Steps: []v1beta1.Step{{Container: corev1.Container{
Name: "name",
Expand Down
11 changes: 7 additions & 4 deletions test/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,14 @@ function run_e2e() {
go_test_e2e -tags=examples -timeout=20m ./test/ || failed=1
}

set_feature_gate "stable"
run_e2e
if [ "$PIPELINE_FEATURE_GATE" == "" ]; then
set_feature_gate "stable"
run_e2e
else
set_feature_gate "$PIPELINE_FEATURE_GATE"
run_e2e
fi

set_feature_gate "alpha"
run_e2e

(( failed )) && fail_test
success

0 comments on commit a7219ea

Please sign in to comment.