Skip to content

Commit

Permalink
Use kubectl create instead of apply
Browse files Browse the repository at this point in the history
When running YAML E2E tests, use kubectl create instead of apply,
so that example can use generateName, which is a best practice
for run objects (TaskRun/PipelineRun).

Fixes #1397
  • Loading branch information
afrittoli committed Oct 9, 2019
1 parent ef8a6b2 commit a748a19
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ function create_resources() {

# Applying the resources, either *taskruns or * *pipelineruns
for file in $(find ${REPO_ROOT_DIR}/examples/${resource}s/ -name *.yaml | sort); do
perl -p -e 's/gcr.io\/christiewilson-catfactory/$ENV{KO_DOCKER_REPO}/g' ${file} | ko apply -f - || return 1
perl -p -e 's/gcr.io\/christiewilson-catfactory/$ENV{KO_DOCKER_REPO}/g' ${file} | ko create -f - || return 1
done
}

Expand Down

0 comments on commit a748a19

Please sign in to comment.