Skip *heavy* validation on deletion 🙃

When deleting an object, we don't need to pursue all the validation
that we do at creation. It reduces the work to be done as part of the
validation *and* allows invalid version of the resource (from previous
versions for example) to be deleted safely.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

pkg/apis/pipeline/v1alpha1/cluster_task_validation.go

@@ -29,5 +29,8 @@ func (t *ClusterTask) Validate(ctx context.Context) *apis.FieldError {
 	if err := validate.ObjectMetadata(t.GetObjectMeta()); err != nil {
 		return err.ViaField("metadata")
 	}
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return t.Spec.Validate(ctx)
 }

pkg/apis/pipeline/v1alpha1/condition_validation.go

@@ -32,6 +32,9 @@ func (c Condition) Validate(ctx context.Context) *apis.FieldError {
 	if err := validate.ObjectMetadata(c.GetObjectMeta()); err != nil {
 		return err.ViaField("metadata")
 	}
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return c.Spec.Validate(ctx).ViaField("Spec")
 }
 

pkg/apis/pipeline/v1alpha1/pipeline_validation.go

@@ -39,6 +39,9 @@ func (p *Pipeline) Validate(ctx context.Context) *apis.FieldError {
 	if err := validate.ObjectMetadata(p.GetObjectMeta()); err != nil {
 		return err.ViaField("metadata")
 	}
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return p.Spec.Validate(ctx)
 }
 

pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go

@@ -32,6 +32,9 @@ func (pr *PipelineRun) Validate(ctx context.Context) *apis.FieldError {
 	if err := validate.ObjectMetadata(pr.GetObjectMeta()).ViaField("metadata"); err != nil {
 		return err
 	}
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return pr.Spec.Validate(ctx)
 }
 

pkg/apis/pipeline/v1alpha1/run_validation.go

@@ -31,6 +31,9 @@ func (r *Run) Validate(ctx context.Context) *apis.FieldError {
 	if err := validate.ObjectMetadata(r.GetObjectMeta()).ViaField("metadata"); err != nil {
 		return err
 	}
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return r.Spec.Validate(ctx)
 }
 

pkg/apis/pipeline/v1alpha1/task_validation.go

@@ -37,6 +37,9 @@ func (t *Task) Validate(ctx context.Context) *apis.FieldError {
 	if err := validate.ObjectMetadata(t.GetObjectMeta()); err != nil {
 		return err.ViaField("metadata")
 	}
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return t.Spec.Validate(ctx)
 }
 

pkg/apis/pipeline/v1alpha1/taskrun_validation.go

@@ -34,6 +34,9 @@ func (tr *TaskRun) Validate(ctx context.Context) *apis.FieldError {
 	if err := validate.ObjectMetadata(tr.GetObjectMeta()).ViaField("metadata"); err != nil {
 		return err
 	}
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return tr.Spec.Validate(ctx)
 }
 

pkg/apis/pipeline/v1beta1/cluster_task_validation.go

@@ -27,5 +27,8 @@ var _ apis.Validatable = (*ClusterTask)(nil)
 
 func (t *ClusterTask) Validate(ctx context.Context) *apis.FieldError {
 	errs := validate.ObjectMetadata(t.GetObjectMeta()).ViaField("metadata")
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return errs.Also(t.Spec.Validate(apis.WithinSpec(ctx)).ViaField("spec"))
 }

pkg/apis/pipeline/v1beta1/pipeline_validation.go

@@ -36,6 +36,9 @@ var _ apis.Validatable = (*Pipeline)(nil)
 // that any references resources exist, that is done at run time.
 func (p *Pipeline) Validate(ctx context.Context) *apis.FieldError {
 	errs := validate.ObjectMetadata(p.GetObjectMeta()).ViaField("metadata")
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return errs.Also(p.Spec.Validate(apis.WithinSpec(ctx)).ViaField("spec"))
 }
 

pkg/apis/pipeline/v1beta1/pipelinerun_validation.go

@@ -32,6 +32,10 @@ var _ apis.Validatable = (*PipelineRun)(nil)
 func (pr *PipelineRun) Validate(ctx context.Context) *apis.FieldError {
 	errs := validate.ObjectMetadata(pr.GetObjectMeta()).ViaField("metadata")
 
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
+
 	if pr.IsPending() && pr.HasStarted() {
 		errs = errs.Also(apis.ErrInvalidValue("PipelineRun cannot be Pending after it is started", "spec.status"))
 	}

pkg/apis/pipeline/v1beta1/task_validation.go

@@ -36,6 +36,9 @@ var _ apis.Validatable = (*Task)(nil)
 
 func (t *Task) Validate(ctx context.Context) *apis.FieldError {
 	errs := validate.ObjectMetadata(t.GetObjectMeta()).ViaField("metadata")
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return errs.Also(t.Spec.Validate(apis.WithinSpec(ctx)).ViaField("spec"))
 }
 

pkg/apis/pipeline/v1beta1/taskrun_validation.go

@@ -33,6 +33,9 @@ var _ apis.Validatable = (*TaskRun)(nil)
 // Validate taskrun
 func (tr *TaskRun) Validate(ctx context.Context) *apis.FieldError {
 	errs := validate.ObjectMetadata(tr.GetObjectMeta()).ViaField("metadata")
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return errs.Also(tr.Spec.Validate(apis.WithinSpec(ctx)).ViaField("spec"))
 }
 

pkg/apis/resource/v1alpha1/pipelineresource_validation.go

@@ -34,7 +34,9 @@ func (r *PipelineResource) Validate(ctx context.Context) *apis.FieldError {
 	if err := validate.ObjectMetadata(r.GetObjectMeta()); err != nil {
 		return err.ViaField("metadata")
 	}
-
+	if apis.IsInDelete(ctx) {
+		return nil
+	}
 	return r.Spec.Validate(ctx)
 }