Ensure resource defaulting is always done regardless of ref type.

Previously we were only setting defaults for k8s API based resources.
This change ensures defaulting is done after we've extracted the
spec, making it agnostic to the resolver type.

pkg/reconciler/pipelinerun/pipelinespec/pipelinespec.go

@@ -43,7 +43,6 @@ func GetPipelineData(ctx context.Context, pipelineRun *v1beta1.PipelineRun, getP
 		}
 		pipelineMeta = t.PipelineMetadata()
 		pipelineSpec = t.PipelineSpec()
-		pipelineSpec.SetDefaults(ctx)
 	case pipelineRun.Spec.PipelineSpec != nil:
 		pipelineMeta = pipelineRun.ObjectMeta
 		pipelineSpec = *pipelineRun.Spec.PipelineSpec
@@ -61,5 +60,7 @@ func GetPipelineData(ctx context.Context, pipelineRun *v1beta1.PipelineRun, getP
 	default:
 		return nil, nil, fmt.Errorf("pipelineRun %s not providing PipelineRef or PipelineSpec", pipelineRun.Name)
 	}
+
+	pipelineSpec.SetDefaults(ctx)
 	return &pipelineMeta, &pipelineSpec, nil
 }

pkg/reconciler/pipelinerun/pipelinespec/pipelinespec_test.go

@@ -143,6 +143,7 @@ func TestGetPipelineData_ResolutionSuccess(t *testing.T) {
 		Tasks: []v1beta1.PipelineTask{{
 			Name: "pt1",
 			TaskRef: &v1beta1.TaskRef{
+				Kind: "Task",
 				Name: "tref",
 			},
 		}},

pkg/reconciler/taskrun/resources/taskspec.go

@@ -49,7 +49,6 @@ func GetTaskData(ctx context.Context, taskRun *v1beta1.TaskRun, getTask GetTask)
 		}
 		taskMeta = t.TaskMetadata()
 		taskSpec = t.TaskSpec()
-		taskSpec.SetDefaults(ctx)
 	case taskRun.Spec.TaskSpec != nil:
 		taskMeta = taskRun.ObjectMeta
 		taskSpec = *taskRun.Spec.TaskSpec
@@ -67,5 +66,7 @@ func GetTaskData(ctx context.Context, taskRun *v1beta1.TaskRun, getTask GetTask)
 	default:
 		return nil, nil, fmt.Errorf("taskRun %s not providing TaskRef or TaskSpec", taskRun.Name)
 	}
+
+	taskSpec.SetDefaults(ctx)
 	return &taskMeta, &taskSpec, nil
 }