Skip to content

Commit

Permalink
Remove SCRIPT_ROOT, CODEGEN_PKG and KNATIVE_CODEGEN_PKG env πŸ˜…
Browse files Browse the repository at this point in the history
Those environment variables are not used in the rest of the script and
thus consume resources (`go list …`) for nothing.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester authored and tekton-robot committed Dec 19, 2019
1 parent 9fc8bcf commit de5493e
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions hack/update-codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ set -o pipefail

source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh

SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
CODEGEN_PKG=${CODEGEN_PKG:-$(go list -m -f '{{.Dir}}' k8s.io/code-generator)}

KNATIVE_CODEGEN_PKG=${KNATIVE_CODEGEN_PKG:-$(go list -m -f '{{.Dir}}' knative.dev/pkg)}

# generate the code with:
# --output-base because this script should also be able to run inside the vendor dir of
# k8s.io/kubernetes. The output-base is needed for the generators to output into the vendor dir
Expand Down

0 comments on commit de5493e

Please sign in to comment.