Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to specify default service accounts #1213

Closed
sthaha opened this issue Aug 19, 2019 · 1 comment · Fixed by #1227
Closed

Provide a way to specify default service accounts #1213

sthaha opened this issue Aug 19, 2019 · 1 comment · Fixed by #1227
Assignees
@sthaha

Comments

@sthaha
Copy link
Member

sthaha commented Aug 19, 2019

Expected Behavior

Currently when a PipelineRun/TaskRun is created without any serviceAccount set, it remains empty. The proposal is to provide a way to set a default serviceAccount if none is specified.

Additional Info

I believe this can be achieved by using the current SetDefaults() mechanism.
@vdemeester
Copy link
Member

To add a bit more, this would be something that can be configured (using the config-defaults config map) 👼

/assign @sthaha

sthaha added a commit to sthaha/build-pipeline that referenced this issue Aug 21, 2019
@sthaha
Provide a way to specify default service accounts
b2308d7 
This PR allows defaults service-account (configurable though the configmap)
to be set  when none is specified in a PipelineRun.

Fixes: tektoncd#1213
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
@sthaha sthaha mentioned this issue Aug 21, 2019
Merged
2 tasks
sthaha added a commit to sthaha/build-pipeline that referenced this issue Aug 21, 2019
@sthaha
Provide a way to specify default service accounts
f80266a 
This PR allows defaults service-account (configurable though the configmap)
to be set  when none is specified in a PipelineRun.

Fixes: tektoncd#1213
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha added a commit to sthaha/build-pipeline that referenced this issue Sep 18, 2019
@sthaha
Provide a way to specify default service accounts
df8e5c0 
This PR allows defaults service-account (configurable though the configmap)
to be set  when none is specified in a PipelineRun.

Fixes: tektoncd#1213
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha added a commit to sthaha/build-pipeline that referenced this issue Sep 27, 2019
@sthaha
Provide a way to specify default service accounts
7e5e80d 
This PR allows defaults service-account (configurable though the configmap)
to be set  when none is specified in a PipelineRun.

Fixes: tektoncd#1213
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha added a commit to sthaha/build-pipeline that referenced this issue Sep 27, 2019
@sthaha
Provide a way to specify default service accounts
9d96e7b 
This PR allows defaults service-account (configurable though the configmap)
to be set  when none is specified in a PipelineRun.

Fixes: tektoncd#1213
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
tekton-robot pushed a commit that referenced this issue Oct 2, 2019
@sthaha @tekton-robot
Provide a way to specify default service accounts
5563e21 
This PR allows defaults service-account (configurable though the configmap)
to be set  when none is specified in a PipelineRun.

Fixes: #1213
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sthaha sthaha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide a way to specify default service accounts sthaha/build-pipeline
2 participants
@vdemeester @sthaha