GCS resource "dir" field is confusing

[bobcatfish]

Expected Behavior

As much as possible it should be clear from the names of PipelineResource params what they do and what values they expect.

Actual Behavior

The GCS Resource dir param basically tells the command that grabs the source whether it should grab the source recursively or not, but dir doesn't really convey that.

Also it can have literally any value (except ""), which is confusing.

Additional Info

• recursive might be a better name
• Or can we find a way to drop this field entirely?
• Note also Design PipelineResource extensibility #238 is completely changing the PipelineResource spec, we should probably hold off on this until then, when we could make this a boolean field.

[bobcatfish]

Marking this as blocked by #238

[vdemeester]

@bobcatfish what is the status ? I guess it still is blocked on the PipelineResource design work 👼

[vdemeester]

/area api
/kind question

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.