Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit an Event when a set affinity property is overwritten #2678

Closed
jlpettersson opened this issue May 23, 2020 · 5 comments · Fixed by #2859
Closed

Emit an Event when a set affinity property is overwritten #2678

jlpettersson opened this issue May 23, 2020 · 5 comments · Fixed by #2859
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jlpettersson
Copy link
Member

jlpettersson commented May 23, 2020 •
edited
Loading

Expected Behavior

That it is easy to detect misconfiguration or conflicting configurations

Actual Behavior

The Affinity Assistant will set affinity on TaskRun pods, but not check or warning is done if the affinity filed already had a value set. An Event should be generated if this happens. Requested in #2630 (comment)

/kind feature
/kind cleanup
@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 23, 2020
adshmh added a commit to adshmh/pipeline that referenced this issue Jun 24, 2020
@adshmh
Emit an event if overwriting PodTemplate affinity
8a765be 
The taskrun controller now emits a warning event if the affinity
specified by pod template will be overwritten with affinity assistant.
Closes tektoncd#2678
@adshmh adshmh mentioned this issue Jun 24, 2020
Merged
4 tasks
adshmh added a commit to adshmh/pipeline that referenced this issue Jun 25, 2020
@adshmh
Emit an event if overwriting PodTemplate affinity
7ee173b 
The taskrun controller now emits a warning event if the affinity
specified by pod template will be overwritten with affinity assistant.
Closes tektoncd#2678
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020
@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

@tekton-robot tekton-robot reopened this Aug 17, 2020
@tekton-robot
Copy link
Collaborator

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 17, 2020
adshmh added a commit to adshmh/pipeline that referenced this issue Sep 29, 2020
@adshmh
Emit an event if overwriting PodTemplate affinity
bc7e8b2 
The taskrun controller now emits a warning event if the affinity
specified by pod template will be overwritten with affinity assistant.
Closes tektoncd#2678
adshmh added a commit to adshmh/pipeline that referenced this issue Sep 29, 2020
@adshmh
Emit an event if overwriting PodTemplate affinity
380c8c4 
The taskrun controller now emits a warning event if the affinity
specified by pod template will be overwritten with affinity assistant.
Closes tektoncd#2678
tekton-robot pushed a commit that referenced this issue Oct 2, 2020
@adshmh @tekton-robot
Emit an event if overwriting PodTemplate affinity
d98d204 
The taskrun controller now emits a warning event if the affinity
specified by pod template will be overwritten with affinity assistant.
Closes #2678
AverageMarcus pushed a commit to AverageMarcus/pipeline that referenced this issue Oct 23, 2020
@adshmh @AverageMarcus
Emit an event if overwriting PodTemplate affinity
2f0780d 
The taskrun controller now emits a warning event if the affinity
specified by pod template will be overwritten with affinity assistant.
Closes tektoncd#2678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit an event if overwriting PodTemplate affinity adshmh/pipeline
3 participants
@vdemeester @jlpettersson @tekton-robot