-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functionality that cancels the TaskRun when the pod encounters an error such as InvalidImageName #4890
Comments
related PR: #4618 |
I don't think it should be possible to create a TaskRun with an invalid image name, since we parse and lookup the requested image in order to resolve the entrypoint. I suppose it's possible that if the image is specified by digest and the command is set, we might not do the lookup (I'm not sure, I'd have to check), and that in that case if the specified image name is invalid, we'd let it proceed and create the Pod, but in general I think the answer is to validate and fail early in that case instead of letting the Pod run until the image name can be corrected. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Feature request
Add functionality to cancel the taskrun when the pod encounters an error that maybe can not be fixed like InvalidImageName
Use case
When the taskrun related pod is pending for some image error, we should let users choose if they want to cancel the taskrun or not. For example, when the pod is pending for InvalidImageName the user may want to cancel the taskrun.
related discussion: #4846 (comment)
The text was updated successfully, but these errors were encountered: