-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vendored-source logic to full release pipeline #1340
Conversation
tektoncd#1338 added this logic to the nightly release pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
/cc @bobcatfish
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
/meow space
tar cvfz ${TMPDIR}/source.tar.gz vendor/ | ||
for d in cmd/*; do | ||
ln -s ${TMPDIR}/source.tar.gz ${d}/kodata/ | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wish we had a Task (or even maybe a reusable step??? #1260 ) we could test and reuse for this bit of bash :D
p.s. just a thought - i think i would have made this a separate step? probably just a stylistic difference tho
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#1338 added this logic to the nightly release pipeline.
Also add
cmd/entrypoint/kodata/
to prevent release pipeline failures.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
/assign @afrittoli