-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using S3-compatible APIs instead of GCS by passing through a boto configuration file. #1361
Conversation
Hi @jbarrick-mesosphere. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test These changes look fine to me but I'm not familiar with the boto SDK. Anyone else have thoughts on this? @bobcatfish @dibyom @vdemeester @afrittoli |
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
Looks good to me, but it needs a rebase. |
…rough a boto configuration file.
13682c8
to
452d209
Compare
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
Thanks @sbwsg I think the tests should be all set on this one 👍 |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for this! |
BTW, I don't know if this was intentional, but this has the side effect that the GCS Pipeline Resource can also be used now to access an S3 storage: pipeline/pkg/apis/pipeline/v1alpha1/gcs_resource.go Lines 113 to 122 in cbeddf0
I tried altering the GCS taskrun example to use a COS bucket on IBM Cloud with s3 service credentials enabled, and it works like a charm:
|
Glad it’s useful for others! As far as I know any of the GCS features that use gsutil should work with any S3 now - I’ve been using the pipeline resource with Minio. I should put up a Minio example, too. |
I started testing s3 artifacts storage today, and couldn’t get it to work in another region than us-east-1. Is this a known limitation of gsutil working only in us-east-1 ? |
I ran into this too when trying to get minio working, it seems to be an upstream issue in gsutil that needs to be fixed there. I worked around it by creating a Kubernetes service called |
@jbarrick-mesosphere thanks for confirming the issue. |
Changes
This adds support for using S3-compatible APIs instead of GCS with the GCS storage resource.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes