Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubectl create instead of apply #1398

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Use kubectl create instead of apply #1398

merged 1 commit into from
Oct 14, 2019

Commits on Oct 14, 2019

  1. Use kubectl create instead of apply 

    When running YAML E2E tests, use kubectl create instead of apply,
so that example can use generateName, which is a best practice
for run objects (TaskRun/PipelineRun).

Using "create" also exposed name conflicts for several resources
all named the same. Luckily the content of those secret was the
same, so we had no race condition in the past, but it's best
to avoid side effects between tests as much as possible and
keep resource names uniques across examples.

With this change we start running taskrun tests again, and it
turns out the gitlab test is broken because of a broken gitlab URL.
Introduce a subfolder for examples that are valid but that we
don't want to run in CI because they need some access to a
resource which is not available.

The Gitlab test has been removed before this was merged, but
keeping the no-ci folder anyways as it may be useful for examples
that we have no easy way to run in CI.

Fixes tektoncd#1397
    @afrittoli
    afrittoli committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    ce742d7 View commit details
    Browse the repository at this point in the history