Handle injected sidecars more correctly #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, sidecars that are injected into the Pod by external Mutating Admission Controllers would not be guaranteed to be Ready before starting the first step, and would not be correctly stopped when steps finish. This is because we only considered containers with names starting with "sidecar-" as sidecars, and injected sidecars might have another name. Instead, with this change, we look for any *non-step* container, which must (currently) indicate a sidecar container, when waiting for or stopping sidecars. An added test covers this new behavior, which would have failed before this change.
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, sidecars that are injected into the Pod by external
Mutating Admission Controllers would not be guaranteed to be Ready
before starting the first step, and would not be correctly stopped when
steps finish.
This is because we only considered containers with names starting with
"sidecar-" as sidecars, and injected sidecars might have another name.
Instead, with this change, we look for any non-step container, which
must (currently) indicate a sidecar container, when waiting for or
stopping sidecars.
An added test covers this new behavior, which would have failed before
this change.
In general, we could use better e2e test coverage for injected sidecars (#1687)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes