Add TaskRun to v1alpha2 🎋 #1725

vdemeester · 2019-12-10T16:47:19Z

Changes

This modify how TaskRunSpec looks from v1alpha1:

params is now directly under spec
no more inputs and outputs, get replaced by resources
resource has input and output resource declaration fields, similar
to how it is used in Pipeline

The next step are :

Add more types (Pipeline, PipelineRun, Condition)
Refactor v1alpha1 to embedded v1alpha2 (for storage purpose)
Auto-conversion from v1alpha1

The spec will look like this (only thing that changed from v1alpha1).

spec:
  params:
     # params here
  resources:
    inputs:
      # inputs resources here
    outputs:
      # outputs resource here

One important thing to note here though, is as we are keeping the current PipelineResource as alpha, I can't have embedded ResourceSpec in TaskRun if we keep PipelineResource in the same api group... 😅 😓. (That said, we may be able to do something hacky to bypass that problem 🙈 )

This should more or less fix #1185

Depends on #1706 and #1720 😅

/hold

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

tekton-robot · 2019-12-10T16:50:18Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/contexts.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	96.2%

bobcatfish · 2019-12-10T16:55:11Z

One important thing to note here though, is as we are keeping the current PipelineResource as alpha, I can't have embedded ResourceSpec in TaskRun if we keep PipelineResource in the same api group... 😅 sweat. (That said, we may be able to do something hacky to bypass that problem 🙈 )

I think we should try to do something hacky and bypass it so that we can embed ResourceSpecs in TaskRuns even though they are alpha.

bobcatfish · 2019-12-10T16:57:07Z

pkg/apis/pipeline/v1alpha2/resource_types.go

+	// ResourceSpec is specification of a resource that should be created and
+	// consumed by the task
+	// +optional
+	// ResourceSpec *PipelineResourceSpec `json:"resourceSpec,omitempty"`


what if we move resources e.g. something like pkg/apis/resources/v1alpha1 <-- i think then we'd be able to import resources here?

@bobcatfish I can see multiple ways indeed 👼 I just need to see how easy or hard it is to bend the generators 👼 😈

I am going to try that change in a separate PR btw 👼

@bobcatfish experiment on this #1773 😅

vdemeester · 2019-12-10T16:59:22Z

I think we should try to do something hacky and bypass it so that we can embed ResourceSpecs in TaskRuns even though they are alpha.

Ok, will look into that 🙊

bobcatfish · 2019-12-10T17:00:23Z

pkg/apis/pipeline/v1alpha2/taskrun_types.go

+limitations under the License.
+*/
+
+package v1alpha2


one thing thats not clear to me reviewing: how many of these files and tests are duplicated from v1alpha1 and how many are new? (maybe we can include a docstring or something in the copied files explaining that, maybe in the v1lapha1 version, something like "this file is frozen, changes should now happen in " <-- we could even add automation if we do that to make sure ppl aren't changing files they shouldnt)

bumpin this 😇

bobcatfish · 2019-12-10T17:01:38Z

resource has input and output resource declaration fields, similar to how it is used in Pipeline

I think I'm doing a bad job of looking and/or dont know what im looking for: @vdemeester where can I find the logic that will automatically convert v1alpha1 TaskRuns that use the old syntax to the new v1alpha2 syntax?

vdemeester · 2019-12-10T17:04:18Z

I think I'm doing a bad job of looking and/or dont know what im looking for: @vdemeester where can I find the logic that will automatically convert v1alpha1 TaskRuns that use the old syntax to the new v1alpha2 syntax?

well, nowhere :

The next step are :

    Add more types (Pipeline, PipelineRun, Condition)
    Refactor v1alpha1 to embedded v1alpha2 (for storage purpose)
    Auto-conversion from v1alpha1

In a follow-up 🙇‍♂️

tekton-robot · 2019-12-11T08:19:17Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/contexts.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	96.2%

tekton-robot · 2019-12-12T12:52:44Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	96.2%

tekton-robot · 2019-12-16T13:13:30Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	96.2%

vdemeester · 2020-01-09T13:32:26Z

Rebased but depends on #1773 if we want to support PipelineResource embedded in v1alpha2.

tekton-robot · 2020-01-09T13:33:21Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	96.2%

tekton-robot · 2020-01-10T09:58:52Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	96.2%

vdemeester · 2020-01-10T10:07:27Z

/hold cancel

vdemeester · 2020-01-10T10:27:41Z

/test pull-tekton-pipeline-integration-tests

vdemeester · 2020-01-10T12:58:45Z

/hold

This depends on #1841 too now 👼 😝

tekton-robot · 2020-01-10T13:21:56Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha2/task_validation.go	74.8%	83.1%	8.3
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	97.2%
pkg/apis/pipeline/v1alpha2/workspace_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/workspace_validation.go	Do not exist	100.0%

vdemeester · 2020-01-13T15:30:39Z

/hold cancel

ghost · 2020-01-17T18:13:34Z

Oof. Rebase needed.

/approve

tekton-robot · 2020-01-17T18:13:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2020-01-20T14:00:08Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	97.2%

tekton-robot · 2020-01-20T14:17:45Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	97.2%

This modify how `TaskRunSpec` looks from v1alpha1: - params is now directly under spec - no more inputs and outputs, get replaced by resources - resource has input and output resource declaration fields, similar to how it is used in Pipeline The next step are : - Add more types (Pipeline, PipelineRun, Condition) - Refactor v1alpha1 to embedded v1alpha2 (for storage purpose) - Auto-conversion from v1alpha1 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

chmouel · 2020-01-20T17:11:33Z

/lgtm

Looking Good! 🤙🏽

tekton-robot · 2020-01-20T17:12:42Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	97.2%

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2019

tekton-robot requested review from abayer and afrittoli December 10, 2019 16:47

googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Dec 10, 2019

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 10, 2019

bobcatfish reviewed Dec 10, 2019

View reviewed changes

vdemeester force-pushed the v1alpha2-taskrun branch from 5f3e227 to 55d6c68 Compare December 11, 2019 08:17

vdemeester added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2019

vdemeester force-pushed the v1alpha2-taskrun branch from 55d6c68 to 88f9671 Compare December 12, 2019 12:50

vdemeester force-pushed the v1alpha2-taskrun branch from 88f9671 to f12eea0 Compare December 16, 2019 13:11

vdemeester mentioned this pull request Dec 19, 2019

Migrate PipelineResource in their own package… 📦 #1773

Merged

3 tasks

vdemeester force-pushed the v1alpha2-taskrun branch from f12eea0 to ef01769 Compare January 9, 2020 13:31

vdemeester force-pushed the v1alpha2-taskrun branch from ef01769 to 2a37514 Compare January 10, 2020 09:56

vdemeester removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2020

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020

vdemeester mentioned this pull request Jan 10, 2020

Add Condition to v1alpha2 🎋 #1846

Closed

3 tasks

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020

vdemeester force-pushed the v1alpha2-taskrun branch 2 times, most recently from 289b59b to 4a20c66 Compare January 10, 2020 13:19

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2020

vdemeester mentioned this pull request Jan 17, 2020

Inconsistency with how we use and parameterize a taskRef #1185

Closed

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020

vdemeester force-pushed the v1alpha2-taskrun branch from 4a20c66 to a4c2595 Compare January 20, 2020 13:56

vdemeester force-pushed the v1alpha2-taskrun branch from a4c2595 to fa08b26 Compare January 20, 2020 14:15

vdemeester force-pushed the v1alpha2-taskrun branch from fa08b26 to b9de9ac Compare January 20, 2020 17:10

tekton-robot assigned chmouel Jan 20, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020

tekton-robot merged commit 99fbc71 into tektoncd:master Jan 20, 2020

vdemeester deleted the v1alpha2-taskrun branch January 20, 2020 17:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TaskRun to v1alpha2 🎋 #1725

Add TaskRun to v1alpha2 🎋 #1725

vdemeester commented Dec 10, 2019 •

edited

Loading

tekton-robot commented Dec 10, 2019

bobcatfish commented Dec 10, 2019

bobcatfish Dec 10, 2019

vdemeester Dec 10, 2019

vdemeester Dec 12, 2019

vdemeester Dec 19, 2019

vdemeester commented Dec 10, 2019

bobcatfish Dec 10, 2019

bobcatfish Jan 9, 2020

bobcatfish commented Dec 10, 2019

vdemeester commented Dec 10, 2019

tekton-robot commented Dec 11, 2019

tekton-robot commented Dec 12, 2019

tekton-robot commented Dec 16, 2019

vdemeester commented Jan 9, 2020

tekton-robot commented Jan 9, 2020

tekton-robot commented Jan 10, 2020

vdemeester commented Jan 10, 2020

vdemeester commented Jan 10, 2020

vdemeester commented Jan 10, 2020

tekton-robot commented Jan 10, 2020

vdemeester commented Jan 13, 2020

ghost commented Jan 17, 2020

tekton-robot commented Jan 17, 2020

tekton-robot commented Jan 20, 2020

tekton-robot commented Jan 20, 2020

chmouel commented Jan 20, 2020

tekton-robot commented Jan 20, 2020

Add TaskRun to v1alpha2 🎋 #1725

Add TaskRun to v1alpha2 🎋 #1725

Conversation

vdemeester commented Dec 10, 2019 • edited Loading

Changes

Submitter Checklist

Reviewer Notes

tekton-robot commented Dec 10, 2019

bobcatfish commented Dec 10, 2019

bobcatfish Dec 10, 2019

Choose a reason for hiding this comment

vdemeester Dec 10, 2019

Choose a reason for hiding this comment

vdemeester Dec 12, 2019

Choose a reason for hiding this comment

vdemeester Dec 19, 2019

Choose a reason for hiding this comment

vdemeester commented Dec 10, 2019

bobcatfish Dec 10, 2019

Choose a reason for hiding this comment

bobcatfish Jan 9, 2020

Choose a reason for hiding this comment

bobcatfish commented Dec 10, 2019

vdemeester commented Dec 10, 2019

tekton-robot commented Dec 11, 2019

tekton-robot commented Dec 12, 2019

tekton-robot commented Dec 16, 2019

vdemeester commented Jan 9, 2020

tekton-robot commented Jan 9, 2020

tekton-robot commented Jan 10, 2020

vdemeester commented Jan 10, 2020

vdemeester commented Jan 10, 2020

vdemeester commented Jan 10, 2020

tekton-robot commented Jan 10, 2020

vdemeester commented Jan 13, 2020

ghost commented Jan 17, 2020

tekton-robot commented Jan 17, 2020

tekton-robot commented Jan 20, 2020

tekton-robot commented Jan 20, 2020

chmouel commented Jan 20, 2020

tekton-robot commented Jan 20, 2020

vdemeester commented Dec 10, 2019 •

edited

Loading