Add jsonpath expand library #1951
Conversation
This adds a "jsonpath" package with an "Expand" function. Functions in expand.go have some basic doc however for now the best examples of usage are in expand_test.go.
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XL
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
tekton-robot
added
the
approved
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was originally added as part of tektoncd#1951 and tektoncd#1493 in January 2020, but the work was never finished and the package isn't used anywhere. It's a non-trivial amount of code and maintenance to keep up to date as we bump linters and scanners, so we should delete it until there's a clear use case. I'm not aware of anyone using this now, so another reason to remove it now is to prevent someone from taking a dependency on it. Signed-off-by: Dan Lorenc <dlorenc@google.com>
This was originally added as part of #1951 and #1493 in January 2020, but the work was never finished and the package isn't used anywhere. It's a non-trivial amount of code and maintenance to keep up to date as we bump linters and scanners, so we should delete it until there's a clear use case. I'm not aware of anyone using this now, so another reason to remove it now is to prevent someone from taking a dependency on it. Signed-off-by: Dan Lorenc <dlorenc@google.com>
Changes
This adds a "jsonpath" package with an "Expand" function. Functions in expand.go have some basic doc however for now the best examples of usage are in expand_test.go.
This is "expand" engine support that is part of #1463
This is not currently user-facing and just a first step.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.