Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update knative.dev/pkg to 0.13, fix breaking Convertible change #2126

Merged
merged 8 commits into from
Mar 5, 2020
Merged

Update knative.dev/pkg to 0.13, fix breaking Convertible change #2126

merged 8 commits into from
Mar 5, 2020

Conversation

mattmoor
Copy link
Member

Fixes: #2125

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Feb 29, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 29, 2020
@tekton-robot
Copy link
Collaborator

Hi @mattmoor. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 29, 2020
@vdemeester
Copy link
Member

/hold
I would looove to get #2035 in before doing that 👼 🙏

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Mar 2, 2020

@vdemeester rebased!

vdemeester
vdemeester approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow
/hold cancel

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 2, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Mar 2, 2020

@vdemeester needs /ok-to-test and /lgtm 😉

@mattmoor mattmoor mentioned this pull request Mar 2, 2020
Merged
@vdemeester
Copy link
Member

/ok-to-test
(I was waiting for someone else to write the lgtm 😛)

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Mar 3, 2020

I was waiting for someone else to write the lgtm

Aha! Are there people I should poke?

@ghost
Copy link

ghost commented Mar 3, 2020

/hold

Do we need this to go in before 0.11? If not I'd prefer to pause merging of a 174 file change until we cut the release tomorrow.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Mar 3, 2020

I'm not in a rush, I mainly want the ability to validate this through CI.

@ghost
Copy link

ghost commented Mar 3, 2020

👍 alright cool, cheers! i'll remove the hold as soon as I finish the release in the morning.

@mattmoor
Copy link
Member Author

mattmoor commented Mar 4, 2020

@vdemeester I'm guessing you have something relying on map ordering in resultrefresolution_test.go 🤔

I'll dig a bit if I get a chance, I've been in meetings like all day 😭

@mattmoor
Copy link
Member Author

mattmoor commented Mar 4, 2020

Alright this now has a set of fixes for various breakages from pkg as well as a fix for a map iteration bug in tekton.

@mattmoor
Copy link
Member Author

mattmoor commented Mar 5, 2020

I wanted to ping this now that your release seems to be cut. LMK if I should change anything.

@ghost
Copy link

ghost commented Mar 5, 2020

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2020
vdemeester
vdemeester approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 1de0c3e into tektoncd:master Mar 5, 2020
@afrittoli afrittoli added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

knative.dev/pkg make breaking change to apis.Convertible
5 participants
@mattmoor @tekton-robot @vdemeester @afrittoli @googlebot