Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize start time for TaskRuns with no sidecars #2158

Merged
merged 1 commit into from
Jun 3, 2020

Commits on May 29, 2020

  1. Optimize start time for TaskRuns with no sidecars

    When no sidercars are present **and** the cluster does not use
    injected sidecars, the pipeline controller can optimize the
    TaskRun Pod creation process by setting the `tekton.dev/ready`
    annotation before pod creation itself instead of setting it after
    the pod has been created.
    
    This commit adds an option to a new `config-features` ConfigMap
    called `running-in-environment-with-injected-sidecars`. Enabling
    this option will decrease the time it takes for a TaskRun to start
    running(when no sidecars are present). However, for clusters that
    use injected sidecars e.g. istio enabling this option can lead to
    unexpected behavior.By default, the option is set to "true" for
    backwards compatibility.
    
    Fixes tektoncd#2080
    
    Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
    dibyom committed May 29, 2020
    Configuration menu
    Copy the full SHA
    c29ab1d View commit details
    Browse the repository at this point in the history