Add params section to Pipelinerun doc #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/L
|
@afrittoli fixes Pipelinerun docs miss params: #2153 |
nikhil-thomas
force-pushed
the
pipelinerun-params-docs
branch
2 times, most recently
from
7df9e08
to
994dbe2
Compare
ghost
approved these changes
Mar 6, 2020
tekton-robot
added
the
approved
Adds params section to Pipelinerun doc to explain how to specify params in a Pipelinerun Spec Add examples in `examples/v1alpha1/pipelineruns` and `examples/v1beta1/pipelineruns` Fixes tektoncd#2153 Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
pipelinerun-params-docs
branch
from
994dbe2
to
9bbc61f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-tekton-pipeline-integration-tests |
afrittoli
added
the
kind/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds params section to Pipelinerun doc to explain
how to specify params in a Pipelinerun Spec
Add examples in
examples/v1alpha1/pipelinerunsandexamples/v1beta1/pipelinerunsFixes Pipelinerun docs miss params: #2153
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes