Add pipeline results #2178

othomann · 2020-03-06T17:59:34Z

Changes

Add pipeline results to the pipeline spec and pipeline run status.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

Release Notes

Add pipeline results to pipeline specs and pipeline run status.

tekton-robot · 2020-03-06T18:01:49Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	96.2%	93.5%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	34.0%	28.6%	-5.4
test/builder/pipeline.go	86.8%	83.6%	-3.2

tekton-robot · 2020-03-06T18:43:48Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	96.2%	93.5%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	34.0%	28.6%	-5.4
test/builder/pipeline.go	86.8%	83.6%	-3.2

tekton-robot · 2020-03-06T18:52:48Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	96.2%	93.5%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	34.0%	28.6%	-5.4
test/builder/pipeline.go	86.8%	83.6%	-3.2

tekton-robot · 2020-03-06T19:12:03Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	96.2%	93.5%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	34.0%	28.6%	-5.4
test/builder/pipeline.go	86.8%	83.6%	-3.2

tekton-robot · 2020-03-06T19:12:42Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	96.2%	93.5%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	34.0%	28.6%	-5.4
test/builder/pipeline.go	86.8%	83.6%	-3.2

othomann · 2020-03-10T19:10:55Z

I rebased on master.

tekton-robot · 2020-03-10T19:12:30Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	96.2%	93.5%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	34.0%	28.6%	-5.4
test/builder/pipeline.go	87.0%	83.8%	-3.1

othomann · 2020-03-11T18:57:53Z

@skaegi @sbwsg any update on reviews?

ghost · 2020-03-12T14:22:19Z

Apologies, I haven't had time to review much the past week or two due to the Beta release coming up. I'm still quite focused on that work so can't commit to reviewing right now. I will try to carve out some time next week (when I am on buildcop rotation) to pick up reviews again. Sorry for the frustrating lack of feedback so far!

tekton-robot · 2020-03-18T17:35:55Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	96.2%	93.5%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	34.0%	28.6%	-5.4
test/builder/pipeline.go	87.1%	84.0%	-3.1

ghost

Really sorry for the delay in reviewing! I've left a bunch of comments but I think the overall approach here is a good way to go.

It would be amazing if we could pull all of the ResultRef-related processing out of the v1beta1 package completely. It lives right now in param_types.go but I feel like it's quickly growing out of the scope of that file. Maybe we could put it in its own package like pkg/result similar to pkg/workspace? Or should we tackle that in a future refactoring PR?

pkg/apis/pipeline/v1beta1/param_types.go

pkg/apis/pipeline/v1beta1/pipelinerun_types.go

pkg/reconciler/pipelinerun/pipelinerun.go

pkg/reconciler/pipelinerun/resources/resultrefresolution.go

tekton-robot · 2020-03-26T15:27:38Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	96.3%	93.7%	-2.6
pkg/apis/pipeline/v1beta1/param_types.go	31.6%	26.9%	-4.7
test/builder/pipeline.go	87.1%	84.0%	-3.1

tekton-robot · 2020-04-01T23:23:49Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	94.4%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	70.0%	-17.5
test/builder/pipeline.go	87.1%	84.0%	-3.1

tekton-robot · 2020-04-02T00:36:50Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	94.4%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	87.1%	-0.4
test/builder/pipeline.go	87.1%	84.0%	-3.1

tekton-robot · 2020-04-02T00:37:25Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	94.4%	-2.7
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	87.1%	-0.4
test/builder/pipeline.go	87.1%	84.0%	-3.1

tekton-robot · 2020-04-03T16:12:50Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	76.2%	78.3%	2.1
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	93.2%	-3.9
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	78.3%	-9.2
pkg/apis/pipeline/v1beta1/resultref.go	Do not exist	90.9%
test/builder/pipeline.go	87.1%	84.0%	-3.1

tekton-robot · 2020-04-03T16:13:06Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	76.2%	78.3%	2.1
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	93.2%	-3.9
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	78.3%	-9.2
pkg/apis/pipeline/v1beta1/resultref.go	Do not exist	90.9%
test/builder/pipeline.go	87.1%	84.0%	-3.1

examples/v1beta1/pipelineruns/pipelinerun-results.yaml

othomann · 2020-04-03T17:38:47Z

/test pull-tekton-pipeline-integration-tests

tekton-robot · 2020-04-03T18:21:20Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	76.2%	78.3%	2.1
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	93.2%	-3.9
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	78.3%	-9.2
pkg/apis/pipeline/v1beta1/resultref.go	Do not exist	90.9%
test/builder/pipeline.go	87.1%	84.0%	-3.1

tekton-robot · 2020-04-03T18:22:36Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	76.2%	78.3%	2.1
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	93.2%	-3.9
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	78.3%	-9.2
pkg/apis/pipeline/v1beta1/resultref.go	Do not exist	90.9%
test/builder/pipeline.go	87.1%	84.0%	-3.1

othomann · 2020-04-03T21:31:59Z

@sbwsg I think I addressed all your concerns. Could you please review the latest input? Thank you.

vdemeester

/meow

tekton-robot · 2020-04-06T07:51:58Z

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2020-04-06T07:52:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ghost · 2020-04-06T12:13:37Z

pkg/apis/pipeline/v1beta1/param_types_test.go

+			if ok {
+				got, err := v1beta1.NewResultRefs(expressions)
+				if tt.wantErr != (err != nil) {
+					t.Errorf("TestNewResultReference/%s wantErr %v, error = %v", tt.name, tt.wantErr, err)


Now that we have resultref.go we should also move these tests into resultref_test.go:

TestNewResultReference

TestHasResultReference

TestLooksLikeResultRef

ok, will do.

If I change that, a new approval will be needed.

tekton-robot · 2020-04-06T15:23:00Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	76.2%	78.3%	2.1
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	93.2%	-3.9
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	78.3%	-9.2
pkg/apis/pipeline/v1beta1/resultref.go	Do not exist	90.9%
test/builder/pipeline.go	87.1%	84.0%	-3.1

tekton-robot · 2020-04-06T15:23:14Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	76.2%	78.3%	2.1
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	93.2%	-3.9
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	78.3%	-9.2
pkg/apis/pipeline/v1beta1/resultref.go	Do not exist	90.9%
test/builder/pipeline.go	87.1%	84.0%	-3.1

tekton-robot · 2020-04-06T15:24:40Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	76.2%	78.3%	2.1
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	93.2%	-3.9
pkg/apis/pipeline/v1beta1/param_types.go	87.5%	78.3%	-9.2
pkg/apis/pipeline/v1beta1/resultref.go	Do not exist	90.9%
test/builder/pipeline.go	87.1%	84.0%	-3.1

ghost · 2020-04-06T16:05:31Z

/lgtm

vdemeester · 2020-04-06T16:37:04Z

🎉

bobcatfish · 2020-04-06T16:49:19Z

Hey @othomann @vdemeester @sbwsg I'm having trouble finding an issue and/or use cases associated with this feature, can you point me in the right direction?

ghost · 2020-04-06T16:50:51Z

Here's the issue: #1950

googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Mar 6, 2020

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 6, 2020

tekton-robot requested review from afrittoli and imjasonh March 6, 2020 17:59

othomann mentioned this pull request Mar 6, 2020

Pipeline Results #1950

Closed

ghost requested a review from skaegi March 6, 2020 18:13

othomann force-pushed the pipeline branch from c446445 to 524362d Compare March 6, 2020 18:50

othomann force-pushed the pipeline branch from 0f003b2 to 3b0521e Compare March 6, 2020 19:08

othomann force-pushed the pipeline branch from 3b0521e to fe86957 Compare March 10, 2020 19:10

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 10, 2020

othomann force-pushed the pipeline branch from fe86957 to cf0c167 Compare March 18, 2020 17:33

ghost reviewed Mar 23, 2020

View reviewed changes

othomann force-pushed the pipeline branch from cf0c167 to 209646b Compare March 26, 2020 15:25

othomann force-pushed the pipeline branch from 209646b to 989338d Compare April 1, 2020 23:21

othomann force-pushed the pipeline branch from c472c8a to d573b82 Compare April 2, 2020 00:35

othomann force-pushed the pipeline branch from 8646082 to 398c9dd Compare April 3, 2020 16:10

ghost reviewed Apr 3, 2020

View reviewed changes

examples/v1beta1/pipelineruns/pipelinerun-results.yaml Outdated Show resolved Hide resolved

othomann force-pushed the pipeline branch from ced3bc7 to b0fcdff Compare April 3, 2020 18:20

vdemeester approved these changes Apr 6, 2020

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020

ghost reviewed Apr 6, 2020

View reviewed changes

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 6, 2020

othomann force-pushed the pipeline branch from 7cffa0f to 8129dd3 Compare April 6, 2020 15:21

Add pipeline results

1e89bd7

othomann force-pushed the pipeline branch from 8129dd3 to 1e89bd7 Compare April 6, 2020 15:22

tekton-robot assigned ghost Apr 6, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020

tekton-robot merged commit a8946d4 into tektoncd:master Apr 6, 2020

afrittoli added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pipeline results #2178

Add pipeline results #2178

othomann commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

othomann commented Mar 10, 2020

tekton-robot commented Mar 10, 2020

othomann commented Mar 11, 2020

ghost commented Mar 12, 2020

tekton-robot commented Mar 18, 2020

ghost left a comment

tekton-robot commented Mar 26, 2020

tekton-robot commented Apr 1, 2020

tekton-robot commented Apr 2, 2020

tekton-robot commented Apr 2, 2020

tekton-robot commented Apr 3, 2020

tekton-robot commented Apr 3, 2020

othomann commented Apr 3, 2020

tekton-robot commented Apr 3, 2020

tekton-robot commented Apr 3, 2020

othomann commented Apr 3, 2020

vdemeester left a comment

tekton-robot commented Apr 6, 2020

tekton-robot commented Apr 6, 2020

ghost Apr 6, 2020

othomann Apr 6, 2020

othomann Apr 6, 2020

tekton-robot commented Apr 6, 2020

tekton-robot commented Apr 6, 2020

tekton-robot commented Apr 6, 2020

ghost commented Apr 6, 2020

vdemeester commented Apr 6, 2020

bobcatfish commented Apr 6, 2020

ghost commented Apr 6, 2020

Add pipeline results #2178

Add pipeline results #2178

Conversation

othomann commented Mar 6, 2020

Changes

Submitter Checklist

Release Notes

tekton-robot commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

tekton-robot commented Mar 6, 2020

othomann commented Mar 10, 2020

tekton-robot commented Mar 10, 2020

othomann commented Mar 11, 2020

ghost commented Mar 12, 2020

tekton-robot commented Mar 18, 2020

ghost left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 26, 2020

tekton-robot commented Apr 1, 2020

tekton-robot commented Apr 2, 2020

tekton-robot commented Apr 2, 2020

tekton-robot commented Apr 3, 2020

tekton-robot commented Apr 3, 2020

othomann commented Apr 3, 2020

tekton-robot commented Apr 3, 2020

tekton-robot commented Apr 3, 2020

othomann commented Apr 3, 2020

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Apr 6, 2020

tekton-robot commented Apr 6, 2020

ghost Apr 6, 2020

Choose a reason for hiding this comment

othomann Apr 6, 2020

Choose a reason for hiding this comment

othomann Apr 6, 2020

Choose a reason for hiding this comment

tekton-robot commented Apr 6, 2020

tekton-robot commented Apr 6, 2020

tekton-robot commented Apr 6, 2020

ghost commented Apr 6, 2020

vdemeester commented Apr 6, 2020

bobcatfish commented Apr 6, 2020

ghost commented Apr 6, 2020