Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Pipeline Nightly Build Times Out On Lint #2259

Merged
merged 1 commit into from Mar 23, 2020
Merged

The Pipeline Nightly Build Times Out On Lint #2259

merged 1 commit into from Mar 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2020

Changes

The most recently pipeline nightly timed out during lint. Looks like
this timeout is set to 5 minutes by default.

This PR introduces a timeout of 10 minutes.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

The most recently pipeline nightly timed out during lint. Looks like
this timeout is set to 5 minutes by default.

This PR introduces a timeout of 10 minutes.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Mar 20, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 20, 2020
@ghost
Copy link
Author

ghost commented Mar 20, 2020

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(I thought we weren't running lint on the nightly anymore ? 😅 )

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@tekton-robot tekton-robot merged commit 7389207 into tektoncd:master Mar 23, 2020
@bobcatfish
Copy link
Collaborator

  1. we werent supposed to be running linting but i didnt finish Remove linting from release pipelines 🧹 #2084 so it didnt get merged - someone must have manually (or automatically?) applied the pipeline in that time
  2. see Ongoing GOLANGCI-LINT timeouts failing PRs and breaking nightly release plumbing#241 for the ongoing effort - i think the best next step is to use a different instance size, waiting 10min for linting is kinda cray

@ghost
Copy link
Author

ghost commented Mar 23, 2020

someone must have manually (or automatically?) applied the pipeline in that time

Indeed this was totally me, as I've been working on 0.11 and 0.10 releases the past few weeks.

@afrittoli afrittoli added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants