Make defaults config map name customizable

[eddycharly]

This PR makes the defaults config map name customizable.

It allows users to override the defaults config map name by specifying a CONFIG_DEFAULTS_NAME environment variable.

This is already the case for artifacts configurations :

pipeline/pkg/artifacts/artifacts_storage.go

Lines 69 to 83 in fbde4aa

	func GetBucketConfigName() string {
	if e := os.Getenv("CONFIG_ARTIFACT_BUCKET_NAME"); e != "" {
	return e
	}
	return "config-artifact-bucket"
	}
	// GetPVCConfigName returns the name of the configmap containing all
	// customizations for the storage PVC.
	func GetPVCConfigName() string {
	if e := os.Getenv("CONFIG_ARTIFACT_PVC_NAME"); e != "" {
	return e
	}
	return "config-artifact-pvc"
	}

If the environment variable is not defined, it uses the config-defaults name.

I would like to have this to be able to generate a unique config map name in a helm chart (see tektoncd/experimental#494).

[tekton-robot]

Hi @eddycharly. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eddycharly]

/assign @abayer

[vdemeester]

/ok-to-test
/cc @imjasonh

[vdemeester]

/lgtm
/meow

[tekton-robot]

@vdemeester:

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eddycharly]

Strange, it doesn't work with webhook...

error: configmap "config-defaults" not found
stacktrace:

github.com/tektoncd/pipeline/vendor/knative.dev/pkg/injection/sharedmain.MainWithConfig
  github.com/tektoncd/pipeline/vendor/knative.dev/pkg/injection/sharedmain/main.go:199
github.com/tektoncd/pipeline/vendor/knative.dev/pkg/injection/sharedmain.MainWithContext
  github.com/tektoncd/pipeline/vendor/knative.dev/pkg/injection/sharedmain/main.go:114
main.main
  github.com/tektoncd/pipeline/cmd/webhook/main.go:136
runtime.main
  runtime/proc.go:203

[eddycharly]

Arf, it wasn't part of the release. My bad, sorry.