Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing omitempty that breaks compatibility #2301

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Add missing omitempty that breaks compatibility #2301

merged 1 commit into from
Mar 27, 2020

Commits on Mar 27, 2020

  1. Add missing omitempty that breaks compatibility 

    Adding "omitempty" on the optional "description" field in WorkspacePipelineDeclaration, to be compatible with previous versions.

v1alpha1 is type aliased with v1beta1, but a new optional field is added.

Submitting without "omitempty" will result in an error from the admission webhook: "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field: "description"

By adding "omitempty" tag, this field is not sent to the server when empty.
    @jlpettersson
    jlpettersson committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    841e2a3 View commit details
    Browse the repository at this point in the history