Makefile: initial setup 🌮 #2310
Conversation
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
googlebot
added
the
cla: yes
tekton-robot
added
the
size/L
| @rm -rf test/tests.* test/coverage.* | ||
|
|
||
| .PHONY: help | ||
| help: |
There was a problem hiding this comment.
What does this one do? Maybe add a comment?
There was a problem hiding this comment.
make help to display help ? 🤔 😅
There was a problem hiding this comment.
There's a lot of regex (and terminal) noise in this entry. I don't understand what it does.
There was a problem hiding this comment.
It's parsing the Makefile to display the help 😛 hence the regex 👼
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm this is awesome! |
|
/test pull-tekton-pipeline-integration-tests |
Changes
The makefile tries to be as-reproductible as possible, aka using specific version of tools, and most importantly, per-repo available tools.
This means it will download and run version of tooling in
$PWD/.binwithout polluting theGOPATHor the go modules.You can override tools too, like if you want to use a specific version of
koor a specific version ofgolangci-lint:Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes