Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a "cheat sheet" for official Tekton Pipelines releases #2428

Merged
merged 1 commit into from Apr 24, 2020
Merged

Provide a "cheat sheet" for official Tekton Pipelines releases #2428

merged 1 commit into from Apr 24, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 16, 2020

Changes

Our existing tekton/README.md and the release instructions from plumbing are excellent resources but they provide a lot of additional context which isn't strictly useful when someone is just trying to perform an official release.

This commit introduces a condensed cheat sheet that just lists the steps to take, in order, when performing an official Tekton Pipelines release. I wrote and then used these instructions for the 0.11.2 release.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@ghost ghost added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 16, 2020
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 16, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 16, 2020
@ghost ghost changed the title Provide a "cheat sheet" for official Tekton releases Provide a "cheat sheet" for official Tekton Pipelines releases Apr 16, 2020

9. The YAMLs are now released! Anyone installing Tekton Pipelines will now get the new version. Time to create a new GitHub release announcement:

1. Create TaskRun YAML file to execute create-draft-release Task.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this process differs from our plumbing repo because right now the official version of tkn (0.8.0) will error out while trying to create the create-draft-release TaskRun. I think this is happening because the create-draft-release Task is v1beta1 and tkn doesn't yet read the params at the top level of the Task spec in v1beta1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering what the tkn command was not working while trying to release Triggers!

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow
/cc @afrittoli

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow
/cc @afrittoli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@dibyom
Copy link
Member

dibyom commented Apr 23, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020
@dibyom
Copy link
Member

dibyom commented Apr 23, 2020

Oh, looks like you might have to rebase/push to make easyCLA happy @sbwsg

Our existing tekton/README.md and the release instructions from plumbing
are excellent resources but they provide a lot of additional context
which isn't strictly useful when someone is just trying to perform an
official release.

This commit introduces a condensed cheat sheet that just lists the steps
to take, in order, when performing an official Tekton Pipelines release.
I wrote and then used these instructions for the 0.11.2 release.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020
@vdemeester
Copy link
Member

/test pull-tekton-pipeline-build-tests

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020
@tekton-robot tekton-robot merged commit 468235f into tektoncd:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants