Re-add tekton.dev/task label to taskruns from ClusterTasks #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #2390 TaskRuns referencing ClusterTasks had their label changed from tekton.dev/task=<Name> to tekton.dev/clusterTask=<Name>. This is a backwards-incompatible change for teams relying on that original task label. This commit adds both labels to TaskRuns referencing ClusterTasks. We can then deprecate the tekton.dev/task= label on these TaskRuns in accordance with Pipelines' API deprecation policy.
ghost
requested review from
|
|
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XS
tekton-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-tekton-pipeline-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In #2390
TaskRunsreferencingClusterTaskshad their label changed fromtekton.dev/task=<Name>totekton.dev/clusterTask=<Name>. This is a backwards-incompatible change for teams relying on that original taskrun label. In an API Working Group call yesterday there was general agreement that we should cover these labels as part of Tekton Pipeline's API Compatibility Policy.This commit adds both labels to
TaskRunsreferencingClusterTasks. We can then deprecate thetekton.dev/task=label on theseTaskRunsin line with the API Compatibility Policy.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes