Externalize Affinity Assistant image #2751
Conversation
tekton-robot
added
the
size/M
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
The following is the coverage report on the affected files.
|
|
What is wrong with using the tekton controller image with a new entrypoint that just sleeps indefinitely ? Then a second image pull is not required, and will always be present. |
jlpettersson
force-pushed
the
externalize_affinity_assistant_image
branch
from
3848cfa
to
cd5b5bf
Compare
jlpettersson
force-pushed
the
externalize_affinity_assistant_image
branch
from
cd5b5bf
to
9d7cf12
Compare
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
/lgtm
/approve
thanks for the quick turnaround @jlpettersson !
as soon as we get this in I can make a 0.13.1 release!
since it turned out there were a couple other fixes we wanted to get into 0.13.1 my plan is to aim for releasing wednesday (https://github.com/tektoncd/pipeline/milestone/29 for the list)
config/controller.yaml
Outdated
|
|
||
| # This image is used as a placeholder pod, the Affinity Assistant | ||
| # TODO(#2640) We may want to create a custom, minimal binary | ||
| # As of June 8, 2020, tag 1.19.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/meow |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From the integration test. Yes, I had fixed the rebase-conflict. But what do I need to do now? Fix it in a different way? Manual merge? |
Container images should not be hardcoded. This commit externalize what image should be used for the Affinity Assistant. /kind misc
jlpettersson
force-pushed
the
externalize_affinity_assistant_image
branch
from
9d7cf12
to
013d64c
Compare
|
I moved my changes in |
|
The following is the coverage report on the affected files.
|
vdemeester
added
the
needs-cherry-pick
nice!!! thanks for that extra attention to making this easy to cherry-pick |
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
vdemeester
removed
the
needs-cherry-pick
Changes
Container images should not be hardcoded.
This commit externalize what image should be used for the Affinity Assistant.
/kind misc
Related to #2640
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.