Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick into 0.13.x: Externalize Affinity Assistant image #2793

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

bobcatfish
Copy link
Collaborator

Changes

Cherry picking this into the 0.13.x release so that anyone downstream of tekton building on it can control the image being used and is able to use the 0.13.x releases

Container images should not be hardcoded.
This commit externalize what image should be used for the Affinity Assistant.

/kind misc

(cherry picked from commit 3c1c49d)

Container images should not be hardcoded.
This commit externalize what image should be used for the Affinity Assistant.

/kind misc

(cherry picked from commit 3c1c49d)
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jun 9, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@bobcatfish bobcatfish changed the base branch from master to release-v0.13.0x June 9, 2020 21:06
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/affinity_assistant.go 91.7% 92.0% 0.3
pkg/reconciler/pipelinerun/pipelinerun.go 81.7% 80.5% -1.2
pkg/reconciler/taskrun/taskrun.go 77.0% 76.0% -1.0

@bobcatfish bobcatfish changed the title Externalize Affinity Assistant image Cherry Pick into 0.13.x: Externalize Affinity Assistant image Jun 9, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow
/cc @afrittoli @sbwsg

@tekton-robot tekton-robot requested review from afrittoli and a user June 10, 2020 08:12
@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow
/cc @afrittoli @sbwsg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Jun 10, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
@tekton-robot tekton-robot merged commit 65c1a88 into tektoncd:release-v0.13.0x Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants