Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Priti as an owner 🎉 #2948

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

bobcatfish
Copy link
Collaborator

Changes

@pritidesai has been a reviewer on many PRs (37 by the count at
https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+is%3Aopen+reviewed-by%3Apritidesai)
and she has been the author of several PRs (27 at https://github.com/tektoncd/pipeline/pulls/pritidesai)
including finally (#2661) which was one of the most substantial changes
to pipeline execution since we implemented DAGs (not to mention that she
patiently worked with the evolution of this feature over several months
from the runOn feature which evolved into this one).

Thanks so much @pritidesai!!!! So excited that you want to become even
more involved in pipelines :D :D :D

p.s. @vdemeester I'm assuming that our intention at least at the moment was to have a 1:1 mapping b/w approvers and apis-approvers

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@pritidesai has been a reviewer on many PRs (37 by the count at
https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+is%3Aopen+reviewed-by%3Apritidesai)
and she has been the author of several PRs (27 at https://github.com/tektoncd/pipeline/pulls/pritidesai)
including finally (tektoncd#2661) which was one of the most substantial changes
to pipeline execution since we implemented DAGs (not to mention that she
patiently worked with the evolution of this feature over several months
from the runOn feature which evolved into this one).

Thanks so much @pritidesai!!!! So excited that you want to become even
more involved in pipelines :D :D :D
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 15, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2020
@bobcatfish
Copy link
Collaborator Author

/hold

PTAL current OWNERS @sbwsg @dibyom @dlorenc @vdemeester @afrittoli @imjasonh

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020
@imjasonh
Copy link
Member

/lgtm

🎉🎉🎉

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@vdemeester
Copy link
Member

/approve
/lgtm
/meow
🙌🏼🙌🏼🙌🏼

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/approve
/lgtm
/meow
🙌🏼🙌🏼🙌🏼

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@dlorenc
Copy link
Contributor

dlorenc commented Jul 15, 2020

/approve
/lgtm

@afrittoli
Copy link
Member

🎉 🎉 🎉
/approve
/lgtm

@vdemeester
Copy link
Member

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 16, 2020
@ghost
Copy link

ghost commented Jul 16, 2020

/lgtm
/approve

😸 🎉 🙌 🎉 🙌 🎉 🙌 🎉 🙌 🎉 😸

@tekton-robot tekton-robot assigned ghost Jul 16, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, dlorenc, sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,dlorenc,sbwsg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bobcatfish
Copy link
Collaborator Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2020
@bobcatfish
Copy link
Collaborator Author

Welcome @pritidesai !!!!! 🎉🎉🎉🎉

image

@tekton-robot tekton-robot merged commit af58372 into tektoncd:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants