-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Priti as an owner 🎉 #2948
Add Priti as an owner 🎉 #2948
Conversation
@pritidesai has been a reviewer on many PRs (37 by the count at https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+is%3Aopen+reviewed-by%3Apritidesai) and she has been the author of several PRs (27 at https://github.com/tektoncd/pipeline/pulls/pritidesai) including finally (tektoncd#2661) which was one of the most substantial changes to pipeline execution since we implemented DAGs (not to mention that she patiently worked with the evolution of this feature over several months from the runOn feature which evolved into this one). Thanks so much @pritidesai!!!! So excited that you want to become even more involved in pipelines :D :D :D
/hold PTAL current OWNERS @sbwsg @dibyom @dlorenc @vdemeester @afrittoli @imjasonh |
/lgtm 🎉🎉🎉 |
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
🎉 🎉 🎉 |
/kind misc |
/lgtm 😸 🎉 🙌 🎉 🙌 🎉 🙌 🎉 🙌 🎉 😸 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, dlorenc, sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Welcome @pritidesai !!!!! 🎉🎉🎉🎉 |
Changes
@pritidesai has been a reviewer on many PRs (37 by the count at
https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+is%3Aopen+reviewed-by%3Apritidesai)
and she has been the author of several PRs (27 at https://github.com/tektoncd/pipeline/pulls/pritidesai)
including finally (#2661) which was one of the most substantial changes
to pipeline execution since we implemented DAGs (not to mention that she
patiently worked with the evolution of this feature over several months
from the runOn feature which evolved into this one).
Thanks so much @pritidesai!!!! So excited that you want to become even
more involved in pipelines :D :D :D
p.s. @vdemeester I'm assuming that our intention at least at the moment was to have a 1:1 mapping b/w approvers and
apis-approvers
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes