Commits on Oct 27, 2020

1. avoid requeuing taskrun in case of permanent error …

   When a taskrun is rejected with permanent error, reconciler should not
   try to requeue the taskrun. After a permanent error is raised in prepare
   function call, reconciler enters the tr.IsDone block. In that block,
   sidecars were being terminated without any check on pod name.
   Such rejected taskrun has no pod name associated with it since a pod is never
   created. Reconciler fails to run such Get command and returns a normal error.
   Next reconciler cycle runs with this normal error instead of permanent error
   and tries to requeue the taskrun until reconciler exhausts the allowed retries.
   
   These changes are introduced to add a check if pod was created for a taskrun
   before cleaning up the sidecars.
   
   Most of the changes in this PR are introduced based on the pipelinerun.go

   

   pritidesai committed Oct 27, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 12e08b0
   • Browse repository at this point

   Copy the full SHA

   12e08b0 View commit details

   Browse the repository at this point in the history