Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up e2e entrypoint_test.go #3199

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Clean up e2e entrypoint_test.go #3199

merged 1 commit into from
Sep 11, 2020

Conversation

imjasonh
Copy link
Member

  • don't use test builders
  • use busybox and script
  • create TaskRun directly
  • copy v1beta1 test to v1alpha1

#3178

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [y] Includes tests (if functionality changed/added)
  • [n] Includes docs (if user facing)
  • [y] Commit messages follow commit message best practices
  • [y] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 10, 2020
@tekton-robot tekton-robot requested review from a user and vdemeester September 10, 2020 18:08
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2020
@imjasonh
Copy link
Member Author

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 10, 2020
@imjasonh
Clean up e2e entrypoint_test.go
8a32960 
- don't use test builders
- use busybox and script
- create TaskRun directly
- copy v1beta1 test to v1alpha1
dlorenc
dlorenc reviewed Sep 10, 2020
View reviewed changes
test/entrypoint_test.go
TaskSpec: &v1beta1.TaskSpec{
Steps: []v1beta1.Step{{
Container: corev1.Container{Image: "busybox"},
Script: "sleep 3 && touch foo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to leave since you're not responsible, but do we know why the sleep 3 is here? It seems like it would have no effect aside from slowing tests down.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If steps are running "at the same time", it's possible this would actually end up touching foo slightly before the other container tries to read it, which could lead to false positives. By sleeping a little we reduce (but admittedly not entirely eliminate) the possibility.

@dlorenc
Copy link
Contributor

dlorenc commented Sep 10, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@imjasonh
Copy link
Member Author

/retest

Flake:

2020/09/10 18:35:19 Error running 'go test -coverprofile ': error='exit status 1'; combined output='go: cloud.google.com/go/storage@v1.8.0: Get https://proxy.golang.org/cloud.google.com/go/storage/@v/v1.8.0.mod: net/http: TLS handshake timeout

@imjasonh
Copy link
Member Author

/test tekton-pipeline-unit-tests

@imjasonh
Copy link
Member Author

/retest

@dibyom
Copy link
Member

dibyom commented Sep 10, 2020

/kind cleanup

@dibyom dibyom added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 10, 2020
vdemeester
vdemeester approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@tekton-robot tekton-robot merged commit e7f6aff into tektoncd:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc left review comments

@vdemeester vdemeester vdemeester approved these changes

Assignees

@dlorenc dlorenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@imjasonh @dlorenc @dibyom @tekton-robot @vdemeester