Update TestPipelineRunWithServiceAccountNameAndTaskRunSpec to use different podtemplate field #3462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified TaskRunSpecs to use different podtemplate fields because using
HostNetwork: true
causes permission issue with downstream projects (like OpenShift)And
TestPipelineRunWithServiceAccountNameAndTaskRunSpec
usecase is to test the emptyness ofServiceAccountName
andTaskRunSpec
so we can specify any podtemplate fileds to verify the scenario.Signed-off-by: Savita Ashture sashture@redhat.com
/cc @vdemeester
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes