Add support for env in podtemplate

[piyush-garg]

This will help to specificy env default, env at pipelinerun
and taskrun level. Env in pod template at taskrun and pipelinerun
level will take precedence over one defined in step and stepTemplate

Env at pipelinerun and taskrun level will override the
default podtemplate

Fix #1606

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Add support for env in default podTemplate, pipelinerun podTemplate and taskrun podTemplate

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	87.4%	88.3%	0.9

[chmouel]

This look good, maybe add an example ? The same way we have on that example ?

[jerop]

please add the env field to the supported fields table in https://github.com/tektoncd/pipeline/blob/ab723e9e79d358b6397cc62a199ba4c489ee3480/docs/podtemplates.md

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	87.4%	89.2%	1.8

[piyush-garg]

@chmouel @vdemeester @jerop I have updated the PR with tests, docs and examples

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	87.4%	89.2%	1.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	87.4%	89.2%	1.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	87.4%	89.2%	1.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	87.4%	89.2%	1.8

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

I'm surprised we didn't want to go ahead with a TEP on this @vdemeester ?

I traced back in the API working group notes and found our discussion on july 20

I know it's a pain to ask for a TEP after the work is already done, but I feel like if it wasn't already done, a TEP would be totally reasonable? Esp. given that this is controversial - or at least it is controversial to me b/c I think folks could use this in such a way that Tekton will replicate the mistakes of other CI/CD systems (which is ironically the motivation for this feature afaik, e.g. migrating from jenkins)

A couple things we might want to cover in a TEP:

• do we want to do this in the pod template or do we want this to be a top level feature? (so it's more obvious) this would also give us more control over which containers these env vars are provided to if we want it
• one thing in the working group I suggested was do we want to make it so that Tasks have to opt into this functionality somehow, i.e. so when you look at a task it's obvious it will also accept some undeclared list of env vars

/hold

[bobcatfish]

nit: environments -> environment variables?

[vdemeester]

I'm surprised we didn't want to go ahead with a TEP on this @vdemeester ?

I traced back in the API working group notes and found our discussion on july 20

I know it's a pain to ask for a TEP after the work is already done, but I feel like if it wasn't already done, a TEP would be totally reasonable? Esp. given that this is controversial - or at least it is controversial to me b/c I think folks could use this in such a way that Tekton will replicate the mistakes of other CI/CD systems (which is ironically the motivation for this feature afaik, e.g. migrating from jenkins)

A couple things we might want to cover in a TEP:

• do we want to do this in the pod template or do we want this to be a top level feature? (so it's more obvious) this would also give us more control over which containers these env vars are provided to if we want it
• one thing in the working group I suggested was do we want to make it so that Tasks have to opt into this functionality somehow, i.e. so when you look at a task it's obvious it will also accept some undeclared list of env vars

/hold

Agreed on all those 🙃

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	87.4%	89.2%	1.8

[tekton-robot]

@piyush-garg: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-pipeline-integration-tests	eb22c76	link	/test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-build-tests	eb22c76	link	/test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tekton-robot]

@piyush-garg: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-pipeline-integration-tests	eb22c76	link	/test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-build-tests	eb22c76	link	/test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

@piyush-garg: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afrittoli]

@vdemeester @piyush-garg any plan to bring this back to live? AFAIK most of the discussion already happened, it was only a matter of formalising it via TEP?