Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step composition to Tasks #3807

Closed
wants to merge 10 commits into from
Closed

Add step composition to Tasks #3807

wants to merge 10 commits into from

Commits on Mar 4, 2021

  1. Add step composition to Tasks

    so that we can reuse steps from tekton catalog or any git repository or OCI bundle easily to promote reuse and avoid copy and paste
    jstrachan committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    8cce40e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. fix: added more unit tests for Task/TaskRun/Pipeline

    so that we can reuse steps in all tekton resources
    jstrachan committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    bf22448 View commit details
    Browse the repository at this point in the history
  2. fix: lets add support for reusing Task resources in k8s

    and align with the TaskRef struct in tekton.
    
    also lets rename the git URI to `git` instead of `path` so its more explicit and fits more cleanly with the `TaskRef`
    jstrachan committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    914aebe View commit details
    Browse the repository at this point in the history
  3. fix: add better vaidation

    jstrachan committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    feef5ee View commit details
    Browse the repository at this point in the history
  4. lets remove the usesTemplate

    as it adds complexity and no longer seems terribly useful when uses: can be a ref/bundle/git
    jstrachan committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    ba2367e View commit details
    Browse the repository at this point in the history
  5. fix: lets avoid the Uses.server property

    so that a single string, `git` can be used like `bundle` to reference versioned files in any git repository using `kpt` style URIs.
    
    Improved support for non-github servers
    
    Given its a single simple string URI, we could also reuse `git` on `TaskRef` some day to reference Tasks on Pipelines using git.
    jstrachan committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    81ea24f View commit details
    Browse the repository at this point in the history
  6. lets remove the old UsesType

    as we no longer need it
    jstrachan committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    8ad1170 View commit details
    Browse the repository at this point in the history
  7. lets move the 'git' property into the TaskRef

    we can then simplify `Uses` to just be an optional `step` name to indicate whether a single step is being used or all of the steps.
    
    We can then look to reuse the git resource loading for `Pipeline.taskRef` too like we do for `bundle`
    jstrachan committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    7ae20d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. lets share the git code with Pipeline.taskRef

    so we can load Tasks from git too
    jstrachan committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    39ee39e View commit details
    Browse the repository at this point in the history
  2. lets avoid using TaskRef directly inside the Uses struct

    as it leads to the confusing 'name' property; lets use 'task' instead then its more clear. It also helps us have better comments to properly describe when and why you would use the 'task' property when using a bundle or git
    jstrachan committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    ee8ee3f View commit details
    Browse the repository at this point in the history