Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list of proposed kind labels for PRs #3987

Merged
merged 1 commit into from
May 27, 2021

Conversation

barthy1
Copy link
Member

@barthy1 barthy1 commented May 27, 2021

Changes

kind/failing-test is not supported kind label at this moment, so better to remove if from the list with suggested labels to avoid error in check-pr-has-kind-label job.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

kind/failing-test is not supported kind label at this moment, so better
to remove if from the list with suggested labels to avoid error in
check-pr-has-kind-label job.

Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 27, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2021
@barthy1 barthy1 changed the title Fix list of proposed kind/* labels for PRs Fix list of proposed kind labels for PRs May 27, 2021
@barthy1 barthy1 closed this May 27, 2021
@barthy1 barthy1 reopened this May 27, 2021
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@afrittoli
Copy link
Member

/test pull-tekton-pipeline-alpha-integration-tests

@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@pritidesai
Copy link
Member

/lgtm

thanks @barthy1, should we remove the label as well or just leave it as is and will add support in future?

Screen Shot 2021-05-27 at 4 06 10 PM

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021
@tekton-robot tekton-robot merged commit 12a7119 into tektoncd:main May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants