Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.24.3 #4024

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Release v0.24.3 #4024

merged 3 commits into from
Jun 9, 2021

Conversation

afrittoli
Copy link
Member

Changes

This is a minor release to fix the delta between v0.24.1 and v0.24.2.

Release v0.24.1 included by mistake three extra commits.
The next minor release v0.24.2 did not include them, but the difference is problematic: #4017

Release v0.24.3 builds on top of v0.24.2 and restores the three extra commits:

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

This is a minor release to fix the delta between v0.24.1 and v0.24.2.

Release v0.24.1 included by mistake three extra commits.
The next minor release v0.24.2 did not include them, but the difference is problematic: https://github.com/tektoncd/pipeline/issues/4017

Release v0.24.3 builds on top of v0.24.2 and restores the three extra commits:

* https://github.com/tektoncd/pipeline/commit/d3666c263237a88bb02f68d9173a9fff7b5fd50e
* https://github.com/tektoncd/pipeline/commit/bf511ddbb8392e3be8036ef697315f7d36089f7f
* https://github.com/tektoncd/pipeline/commit/b31327bd83512658fdcc61f12806dfad41353a40

jerop and others added 3 commits June 9, 2021 10:48
This change removes the deprecated PascalCase fields in `WhenExpressions`

The fields in `WhenExpressions` were missing json annotations in
tektoncd#3135 so they were
PascalCase - released in v0.16

The json annotations were added and supported both PascalCase and
lowercase fields for backwards compatibility in
tektoncd#3291 and
tektoncd#3389 - released in v0.17

The PascalCase fields were deprecated in v0.17, with an earliest date of
removal of Jan 07 2021 - https://github.com/tektoncd/pipeline/blob/v0.23.0/docs/deprecations.md
Prior to this commit the unit tests for AddSidecarVolumeMount did not
execute. The body of the test was effectively a no-op.

This updates the unit test to actually perform the checks intended
when the tests were written. Thankfully the tests pass without any
other changes.
Add links to v0.24.0 docs and examples to the root README

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 9, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2021
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot tekton-robot requested a review from a user June 9, 2021 10:04
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@ghost
Copy link

ghost commented Jun 9, 2021

Would it be worthwhile to cherry-pick #3979 as part of this patch release as well? It fixes a bug with the workingDir default removal on s390x (also I think the problem described in this bug report: #4007)

Otherwise +1 !

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afrittoli
Copy link
Member Author

/retest

@afrittoli
Copy link
Member Author

Would it be worthwhile to cherry-pick #3979 as part of this patch release as well? It fixes a bug with the workingDir default removal on s390x (also I think the problem described in this bug report: #4007)

It sounds like a good idea to me, but I'd add that one as a separate PR then 🙏

Otherwise +1 !

/approve

@jerop
Copy link
Member

jerop commented Jun 9, 2021

thanks for the quick fix @afrittoli!

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@tekton-robot tekton-robot merged commit b35a181 into tektoncd:release-v0.24.x Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants