Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an Informer to list LimitRanges 🥼 #4234

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Use an Informer to list LimitRanges 🥼 #4234

merged 1 commit into from
Sep 16, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Sep 16, 2021 •
edited
Loading

Changes

Using a LimitRange lister here instead, so this doesn't end up hitting
the real API server on each call.

Taking into account a review :
#4176 (comment).

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind cleanup
/cc @imjasonh @bobcatfish @pritidesai @sbwsg @afrittoli

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@vdemeester vdemeester added this to the Pipelines v0.28 milestone Sep 16, 2021
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2021
@vdemeester vdemeester force-pushed the limitrange-use-lister branch 2 times, most recently from 069745c to 71b49ab Compare September 16, 2021 10:23
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 90.9% -1.9

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 93.2% 0.3
test/controller.go 24.5% 23.3% -1.2

@vdemeester
Copy link
Member Author

I am missing something very obvious in the unit tests.. but.. for some reason I don't see it.. 😅

imjasonh
imjasonh reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pkg/internal/limitrange/transformer_test.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 93.2% 0.3

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 90.9% -1.9
pkg/reconciler/taskrun/controller.go 95.0% 95.2% 0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 93.2% 0.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 93.2% 0.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 93.2% 0.3

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imjasonh, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

afrittoli
afrittoli reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
mattmoor
mattmoor reviewed Sep 16, 2021
View reviewed changes
pkg/internal/limitrange/limitrange.go Outdated
)

func getVirtualLimitRange(ctx context.Context, namespace string, c kubernetes.Interface) (*corev1.LimitRange, error) {
limitRanges, err := c.CoreV1().LimitRanges(namespace).List(ctx, metav1.ListOptions{})
limitrangeInformer := limitrangeinformer.Get(ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imjasonh poked me that this PR was having trouble with the injection stuff. I'm guessing it's because this typically gets the context passed to ReconcileKind, which is NOT infused with clients and informers.

To echo my other comment, generally you would grab this off of the context passed to NewController and stash it in a field, to avoid the more "expensive" access during each reconciliation.

TBH I've debated infusing this context with things as well in the past, but until now hadn't really seen a place where it caused confusion. I think allowing that's sort of a mixed bag, and would be hard to walk back, but if you'd like to discuss it I'm open to chatting.

.... but hopefully knowing this at least unblocks you. If not, feel free to ping me!

@vdemeester
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@vdemeester
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 90.7% -2.2
pkg/reconciler/taskrun/controller.go 95.0% 95.2% 0.2

mattmoor
mattmoor reviewed Sep 16, 2021
View reviewed changes
pkg/internal/limitrange/transformer_test.go Outdated
}
}
kubeclient.ClearActions()
return ctx, limitRangeInformer, cancel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consumers just use fakelimitrangeinformer.Get(ctx) instead of returning it here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est pas faux 😝

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est pas faux stuck_out_tongue_closed_eyes

Man I am tired.. "c'est pas faux" means "it's not wrong".. speaking in french while commenting.. makes this.. 😅

mattmoor
mattmoor reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This LGTM, just a nit about setup if you want to preserve the signature.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@mattmoor
Copy link
Member

/hold

In case you want to do the nit, otherwise feel free to remove

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@vdemeester
Use an Informer to list LimitRanges 🥼
9cd860b 
Using a LimitRange lister here instead, so this doesn't end up hitting
the real API server on each call.

Taking into account a review :
tektoncd#4176 (comment).

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/limitrange/limitrange.go 92.9% 93.0% 0.2
pkg/reconciler/taskrun/controller.go 95.0% 95.2% 0.2

mattmoor
mattmoor reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 16, 2021
@tekton-robot tekton-robot merged commit adaae90 into tektoncd:main Sep 16, 2021
@vdemeester vdemeester deleted the limitrange-use-lister branch September 16, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@afrittoli afrittoli afrittoli left review comments

@imjasonh imjasonh imjasonh left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@afrittoli afrittoli

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.28
Development

Successfully merging this pull request may close these issues.
5 participants
@vdemeester @tekton-robot @mattmoor @imjasonh @afrittoli