Remove experimental disable resolution controller flag #4346
Conversation
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/lgtm |
|
@lbernick: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
still getting used to permissions on this repo 😅 anyway, looks good |
tekton-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
In commits 5681ce9 and 5fa4348 we introduced a controller flag to disable resolution of taskRefs and pipelineRefs. This was inteded to support an experimental controller that could externalize resolution of these refs. Tests and documentation for this flag were added as well. The experimental flag ultimately never realized its purpose and the experimental controller was written to only support PipelineRuns started in PipelineRunPending state.
tekton-robot
removed
the
needs-rebase
|
The following is the coverage report on the affected files.
|
|
thanks @sbwsg! /lgtm |
|
test/v1alpha1 TestPipelineTaskTimeout 1m5s /test pull-tekton-pipeline-alpha-integration-tests |
Changes
In commits 5681ce9 and
5fa4348 we introduced a controller flag to
disable resolution of
taskRefsandpipelineRefs. This was intended to support anexperimental controller that could externalize resolution of these refs. Tests
and documentation for this flag were added as well.
The experimental flag ultimately never realized its purpose and the
experimental controller was written to only support PipelineRuns started in
PipelineRunPending state. This commit removes the code, tests and docs
surrounding this flag and its behaviour.
Submitter Checklist
functionality, content, code)
Release Notes
/kind misc