Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PipelineResources #4376

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Deprecate PipelineResources #4376

merged 1 commit into from
Nov 16, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Nov 15, 2021

Changes

When we released Tekton Pipelines Beta in March 2020, we decided not to make PipelineResources Beta.

In TEP-0074, we decided to officially deprecate PipelineResources.

This change announces, documents and warns about the deprecation of PipelineResources.

Follow-on work includes:

Closes #4344.

/kind misc
/cc @bobcatfish

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • [n/a] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

action required: `PipelineResources` are deprecated. Consider using replacement features, such as `Tasks`, instead.

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2021
@jerop jerop marked this pull request as ready for review November 15, 2021 22:31
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2021
@jerop jerop added this to the Pipelines v0.30 milestone Nov 15, 2021
@jerop
Copy link
Member Author

jerop commented Nov 15, 2021

@tektoncd/core-maintainers, hoping make the announcement about deprecation of PipelineResources with release v0.30 - please take a look when you can :)

bobcatfish
bobcatfish reviewed Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough updates and for opening the follow up issues!

I think the earliest removal date isn't quite accurate, but otherwise looks great :D

/approve

docs/auth.md
>
> Consider using replacement features instead. Read more in [documentation](migrating-v1alpha1-to-v1beta1.md#replacing-pipelineresources-with-tasks)
> and [TEP-0074](https://github.com/tektoncd/community/blob/main/teps/0074-deprecate-pipelineresources.md).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice warning syntax! :D

docs/deprecations.md Outdated
| [The `disable-working-dir-overwrite` flag will be removed](https://github.com/tektoncd/pipeline/issues/1836) | [v0.24.0](https://github.com/tektoncd/pipeline/releases/tag/v0.24.0) | Beta | February 10 2022 |
| [The `scope-when-expressions-to-task` flag will be flipped from "false" to "true"](https://github.com/tektoncd/pipeline/issues/1836) | [v0.27.0](https://github.com/tektoncd/pipeline/releases/tag/v0.27.0) | Beta | February 10 2022 |
| [The `scope-when-expressions-to-task` flag will be removed](https://github.com/tektoncd/pipeline/issues/1836) | [v0.27.0](https://github.com/tektoncd/pipeline/releases/tag/v0.27.0) | Beta | March 10 2022 |
| [`PipelineResources` are deprecated.](https://github.com/tektoncd/community/blob/main/teps/0074-deprecate-pipelineresources.md) | [v0.30.0](https://github.com/tektoncd/pipeline/releases/tag/v0.30.0) | Alpha | Dec 20 2022 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since these are alpha i think technically we could remove them 1 month after we announce - so Dec 2021 or Jan 2022

(we definitely won't however)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! meant to say 2021 (already in 2022 with all the planning we've been doing for next year 😃)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THATS BEEN HAPPENING TO ME TOO!!!

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@jerop jerop force-pushed the deprecate-pipeline-resources branch from cde10a7 to 989944b Compare November 16, 2021 03:24
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bobcatfish,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost
Copy link

ghost commented Nov 16, 2021

Looks great!

/lgtm

@tekton-robot tekton-robot assigned ghost Nov 16, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@ghost
Copy link

ghost commented Nov 16, 2021

The workspace-in-sidecar example failed and is a flake.

/test pull-tekton-pipeline-alpha-integration-tests

@jerop
Copy link
Member Author

jerop commented Nov 16, 2021

/test check-pr-has-kind-label

@jerop jerop closed this Nov 16, 2021
@jerop jerop reopened this Nov 16, 2021
@jerop
Copy link
Member Author

jerop commented Nov 16, 2021

(closed and reopened to trigger the check-pr-has-kind-label)

@bobcatfish
Copy link
Collaborator

/test check-pr-has-kind-label

1 similar comment
@bobcatfish
Copy link
Collaborator

/test check-pr-has-kind-label

@bobcatfish
Copy link
Collaborator

AGAIN WITH FEELING

/test check-pr-has-kind-label

@jerop jerop closed this Nov 16, 2021
@jerop jerop reopened this Nov 16, 2021
@jerop jerop closed this Nov 16, 2021
@jerop jerop reopened this Nov 16, 2021
@jerop
Copy link
Member Author

jerop commented Nov 16, 2021

/retest

@jerop jerop closed this Nov 16, 2021
@jerop jerop reopened this Nov 16, 2021
@jerop
Deprecate of PipelineResources
2d23874 
When we [released Tekton Pipelines Beta in March 2020](https://github.com/tektoncd/pipeline/releases/tag/v0.11.0),
we [decided not to make `PipelineResources` Beta](https://github.com/tektoncd/pipeline/blob/e76d4132ab2ecfbedc45a964f08a01022e2d4c14/docs/resources.md#why-arent-pipelineresources-in-beta).

In [TEP-0074](https://github.com/tektoncd/community/blob/main/teps/0074-deprecate-pipelineresources.md),
we decided to officially deprecate `PipelineResources`.

This change announces, documents and warns about the deprecation of
`PipelineResources`.

Follow-on work includes:
- Replace `PipelineResources` from the tutorial - tektoncd#3705
- Replace `PipelineResources` from the examples and documentation - tektoncd#4375
- Continue updating the documentation as work progresses on [TEP-0074](https://github.com/tektoncd/community/blob/main/teps/0074-deprecate-pipelineresources.md)
and features replacing `PipelineResources` become available

Closes tektoncd#4344.
@jerop jerop force-pushed the deprecate-pipeline-resources branch from 989944b to 2d23874 Compare November 16, 2021 21:54
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@jerop
Copy link
Member Author

jerop commented Nov 16, 2021

check-pr-has-kind-label finally ran 😅

@bobcatfish
Copy link
Collaborator

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@tekton-robot tekton-robot merged commit 5997596 into tektoncd:main Nov 16, 2021
@jerop jerop deleted the deprecate-pipeline-resources branch June 11, 2022 01:45
@lbernick lbernick mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish bobcatfish left review comments

@vdemeester vdemeester vdemeester approved these changes

Assignees

@bobcatfish bobcatfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.30
Development

Successfully merging this pull request may close these issues.

Update next Pipelines release to indicate PipelineResources is deprecated
4 participants
@jerop @tekton-robot @bobcatfish @vdemeester