Remove extra log PVC #443
Merged
Remove extra log PVC #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobcatfish
requested review from
imjasonh,
tejal29,
nader-ziada and
shashwathi
googlebot
added
the
cla: yes
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
🤔 /test pull-knative-build-pipeline-integration-tests |
|
Looks like something is wrong with the cluster setup :S gonna have to ping @adrcunha and folks once we're back in regular working hours. |
|
/test pull-knative-build-pipeline-integration-tests |
nader-ziada
reviewed
Jan 28, 2019
|
/test pull-knative-build-pipeline-integration-tests |
1 similar comment
|
/test pull-knative-build-pipeline-integration-tests |
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@bobcatfish this PR just needs to resolve conflicts and would be good to get merged |
bobcatfish
force-pushed
the
disable_extra_pvc
branch
from
b4e7baa
to
31ccf56
Compare
knative-prow-robot
added
size/XL
what have i done |
bobcatfish
force-pushed
the
disable_extra_pvc
branch
from
31ccf56
to
f357829
Compare
bobcatfish
commented
Jan 30, 2019
docs/using.md
Outdated
| overwritten with a custom binary. The plan is to use this custom binary for | ||
| controlling the execution of step containers ([#224](https://github.com/knative/build-pipeline/issues/224)) and log streaming | ||
| [#107](https://github.com/knative/build-pipeline/issues/107), though currently | ||
| it will write logs only to an [`emptyDir`]() (which cannot be read from after |
We noticed early on that logs from init containers are often cleaned up immediately by k8s, particularly if the containers are short running (e.g. just echoing "hello world"). We started down a path to correct that, which takes an approach based on Prow's entrypoint solution (https://github.com/kubernetes/test-infra/tree/master/prow/cmd/entrypoint) (even using the same image at the moment!) which wraps the user's provided command and streams logs to a volume, from which the logs can be uploaded/streamed by a sidecar. Since we are using init containers for step execution, we can't yet use sidecars, but we are addressing that in tektoncd#224 (also an entrypoint re-writing based solution). Once we have that, we can sidecar support, starting with GCS as a POC (#107) and moving into other types. In the meantime, to enable us to get logs (particularly in tests), we had the taskrun controller create a PVC on the fly to hold logs. This has two problems: * The PVCs are not cleaned up so this is an unexpected side effect for users * Combined with PVC based input + ouput linking, this causes scheduling problems for the resulting pods (tektoncd#375) Now that we want to have an official release, this would be a bad state to release in, so we will remove this magical log PVC creation logic, which was never our intended end state anyway. Since we _do_ need the entrypoint rewriting and log interception logic in the long run, this commit leaves most functionality intact, removing only the PVC creation and changing the volume being used to an `emptyDir`, which is what we will likely use for #107 (and this is how Prow handles this as well). This means the released functionality will be streaming logs to a location where nothing can read them, however I think it is better than completely removing the functionality b/c: 1. We need the functionality in the long run 2. Users should be prepared for this functionality (e.g. dealing with edge cases around the taskrun controller being able to fetch an image's entrypoint) Fixes tektoncd#387
bobcatfish
force-pushed
the
disable_extra_pvc
branch
from
f357829
to
1fd6c16
Compare
|
The following is the coverage report on pkg/.
|
|
/lgtm |
bobcatfish
added a commit
to bobcatfish/pipeline
that referenced
this pull request
Feb 6, 2019
Verifying the pipelinerun example worked was disabled due to the combo of tektoncd#375 and tektoncd#443, but now that we've removed the extra log PVC in tektoncd#443 we shouldn't run into this issue anymore :D
bobcatfish
added a commit
to bobcatfish/pipeline
that referenced
this pull request
Feb 6, 2019
Verifying the pipelinerun example worked was disabled due to the combo of tektoncd#375 and tektoncd#443, but now that we've removed the extra log PVC in tektoncd#443 we shouldn't run into this issue anymore :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed early on that logs from init containers are often cleaned up
immediately by k8s, particularly if the containers are short running
(e.g. just echoing "hello world"). We started down a path to correct
that, which takes an approach based on Prow's entrypoint solution
(https://github.com/kubernetes/test-infra/tree/master/prow/cmd/entrypoint)
(even using the same image at the moment!) which wraps the user's
provided command and streams logs to a volume, from which the logs can
be uploaded/streamed by a sidecar.
Since we are using init containers for step execution, we can't yet use
sidecars, but we are addressing that in #224 (also an entrypoint
re-writing based solution). Once we have that, we can sidecar support,
starting with GCS as a POC (#107) and moving into other types.
In the meantime, to enable us to get logs (particularly in tests), we
had the taskrun controller create a PVC on the fly to hold logs. This
has two problems:
users
problems for the resulting pods (TestPipelineRun/fan-in_and_fan-out is broken #375)
Now that we want to have an official release, this would be a bad state
to release in, so we will remove this magical log PVC creation logic,
which was never our intended end state anyway.
Since we do need the entrypoint rewriting and log interception logic
in the long run, this commit leaves most functionality intact, removing
only the PVC creation and changing the volume being used to an
emptyDir, which is what we will likely use for #107 (and this is howProw handles this as well). This means the released functionality will
be streaming logs to a location where nothing can read them, however I
think it is better than completely removing the functionality b/c:
edge cases around the taskrun controller being able to fetch an
image's entrypoint)
Fixes #387
(@pivotal-nader-ziada I think you said you've been refactoring the PVC logic a bunch, so if this conflicts with your changes plz just ignore it, and I'll deal with any rebasing later after you've merged!)