[TEP-0076]Pipeline results support array #4965

Yongxuanzhang · 2022-06-10T15:19:24Z

Changes

This is part of work in TEP-0076.
This commit update the PipelineResult and PipelineRunResult to uspport
array results, meanwhile support the whole array and array indexing
reference from PipelineResult to TaskResult. Before this commit the
pipeline level result only support string.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Docs included if any changes are user facing
Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes

Support array results and indexing array for pipeline level as an alpha feature.

A pipeline can specify a type to create array result, such as:

    results:
      - name: echo-indexing-array-results
        type: string
        description: array element
        value: $(tasks.task1.results.array-results[1])
      - name: echo-array-results
        type: array
        description: whole array
        value: $(tasks.task2.results.array-results[*])

And the task script can populate result in an array form with:

echo -n "[\"hello\",\"world\"]" | tee $(results.array-results.path)

The pipeline results can refer to task results to collect them.
This feature is part of the TEP-0076.

tekton-robot · 2022-06-10T15:22:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

tekton-robot · 2022-06-10T15:38:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

tekton-robot · 2022-06-10T15:39:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

tekton-robot · 2022-06-10T16:23:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

tekton-robot · 2022-06-10T16:36:38Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

tekton-robot · 2022-06-10T19:09:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

Yongxuanzhang · 2022-06-10T19:55:14Z

/test pull-tekton-pipeline-go-coverage

Yongxuanzhang · 2022-06-10T20:27:48Z

/retest

Yongxuanzhang · 2022-06-10T21:22:54Z

/retest

ywluogg · 2022-06-13T15:59:17Z

/assign @ywluogg

ywluogg

NIce job! Everything looks good except some typos

pkg/apis/pipeline/v1beta1/pipeline_types.go

pkg/reconciler/pipelinerun/resources/apply.go

pkg/apis/pipeline/v1beta1/pipeline_types.go

lbernick · 2022-06-15T14:37:07Z

pkg/apis/pipeline/v1beta1/resultref.go

-var arrayIndexingRegex = regexp.MustCompile(arrayIndexing)
+
+// ArrayIndexingRegex is used to match `[int]` and `[*]`
+var ArrayIndexingRegex = regexp.MustCompile(arrayIndexing)


I'm wondering if we need to export this regex or if there is a parsing function it would make more sense to export

oh that's a good point! Let me check if I can have a separate function for this

could you please avoid exporting the regexes here?

it is not exported now

pkg/reconciler/pipelinerun/resources/apply.go

pkg/reconciler/pipelinerun/resources/apply_test.go

tekton-robot · 2022-06-30T02:28:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

ywluogg · 2022-06-30T14:56:15Z

/lgtm

ywluogg · 2022-06-30T14:57:08Z

#4723

Yongxuanzhang · 2022-06-30T15:13:25Z

/retest

lbernick · 2022-06-30T16:19:20Z

pkg/reconciler/pipelinerun/resources/apply.go

+							intIdx, _ := strconv.Atoi(stringIdx)
+							stringReplacements[variable] = resultValue.ArrayVal[intIdx]
+						} else {
+							variable = strings.TrimSuffix(strings.TrimSuffix(strings.TrimPrefix(variable, "$("), ")"), "[*]")


can this be moved into a helper function somewhere? it would be good to have all our string parsing logic in one place.

pkg/apis/pipeline/v1beta1/resultref.go

tekton-robot · 2022-06-30T18:18:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	97.9%	97.9%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

tekton-robot · 2022-07-04T17:40:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, ywluogg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2022-07-04T17:44:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	97.9%	97.9%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

ywluogg · 2022-07-04T18:02:04Z

/lgtm

This is part of work in TEP-0076. This commit update the PipelineResult and PipelineRunResult to uspport array results, meanwhile support the whole array and array indexing reference from PipelineResult to TaskResult. Before this commit the pipeline level result only support string.

tekton-robot · 2022-07-04T18:24:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	97.9%	97.9%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	100.0%	99.2%	-0.8

Yongxuanzhang · 2022-07-04T18:26:53Z

/retest

ywluogg · 2022-07-04T19:08:47Z

/lgtm

tekton-robot requested review from bobcatfish and vdemeester June 10, 2022 15:19

Yongxuanzhang force-pushed the pipeline-array-results branch 2 times, most recently from 9f49461 to 892c284 Compare June 10, 2022 15:36

Yongxuanzhang force-pushed the pipeline-array-results branch from 892c284 to c26cf39 Compare June 10, 2022 16:20

Yongxuanzhang force-pushed the pipeline-array-results branch from c26cf39 to abc94fa Compare June 10, 2022 16:33

Yongxuanzhang force-pushed the pipeline-array-results branch from abc94fa to 1ebb0e7 Compare June 10, 2022 19:05

Yongxuanzhang force-pushed the pipeline-array-results branch from 1ebb0e7 to 6fbe987 Compare June 10, 2022 19:49

Yongxuanzhang marked this pull request as ready for review June 10, 2022 19:59

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2022

tekton-robot assigned ywluogg Jun 13, 2022

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022

Yongxuanzhang force-pushed the pipeline-array-results branch from 6fbe987 to 846e618 Compare June 14, 2022 19:49

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022

Yongxuanzhang force-pushed the pipeline-array-results branch from 846e618 to a5f6bf5 Compare June 14, 2022 20:12

ywluogg approved these changes Jun 15, 2022

View reviewed changes

pkg/apis/pipeline/v1beta1/pipeline_types.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/resources/apply.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/resources/apply.go Outdated Show resolved Hide resolved

lbernick reviewed Jun 15, 2022

View reviewed changes

ywluogg mentioned this pull request Jun 22, 2022

Add ywluogg into Pipeline reviewer roles tektoncd/community#737

Merged

Yongxuanzhang force-pushed the pipeline-array-results branch from e122b33 to a356fdc Compare June 30, 2022 02:22

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022

Yongxuanzhang requested a review from lbernick June 30, 2022 14:58

lbernick reviewed Jun 30, 2022

View reviewed changes

Yongxuanzhang force-pushed the pipeline-array-results branch from a356fdc to a22a53c Compare June 30, 2022 17:49

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022

lbernick approved these changes Jun 30, 2022

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2022

Yongxuanzhang force-pushed the pipeline-array-results branch from a22a53c to 1e482c4 Compare July 4, 2022 17:40

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022

Yongxuanzhang force-pushed the pipeline-array-results branch from 1e482c4 to aa139ec Compare July 4, 2022 18:20

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022

tekton-robot merged commit 0d1d87a into tektoncd:main Jul 4, 2022

Yongxuanzhang mentioned this pull request Sep 27, 2022

Mark tep75&76 implemented tektoncd/community#833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEP-0076]Pipeline results support array #4965

[TEP-0076]Pipeline results support array #4965

Yongxuanzhang commented Jun 10, 2022 •

edited

Loading

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

Yongxuanzhang commented Jun 10, 2022

Yongxuanzhang commented Jun 10, 2022

Yongxuanzhang commented Jun 10, 2022

ywluogg commented Jun 13, 2022

ywluogg left a comment

lbernick Jun 15, 2022

Yongxuanzhang Jun 15, 2022

lbernick Jun 15, 2022

Yongxuanzhang Jun 30, 2022

tekton-robot commented Jun 30, 2022

ywluogg commented Jun 30, 2022

ywluogg commented Jun 30, 2022

Yongxuanzhang commented Jun 30, 2022

lbernick Jun 30, 2022

Yongxuanzhang Jun 30, 2022

tekton-robot commented Jun 30, 2022

tekton-robot commented Jul 4, 2022

tekton-robot commented Jul 4, 2022

ywluogg commented Jul 4, 2022

tekton-robot commented Jul 4, 2022

Yongxuanzhang commented Jul 4, 2022

ywluogg commented Jul 4, 2022

[TEP-0076]Pipeline results support array #4965

[TEP-0076]Pipeline results support array #4965

Conversation

Yongxuanzhang commented Jun 10, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

tekton-robot commented Jun 10, 2022

Yongxuanzhang commented Jun 10, 2022

Yongxuanzhang commented Jun 10, 2022

Yongxuanzhang commented Jun 10, 2022

ywluogg commented Jun 13, 2022

ywluogg left a comment

Choose a reason for hiding this comment

lbernick Jun 15, 2022

Choose a reason for hiding this comment

Yongxuanzhang Jun 15, 2022

Choose a reason for hiding this comment

lbernick Jun 15, 2022

Choose a reason for hiding this comment

Yongxuanzhang Jun 30, 2022

Choose a reason for hiding this comment

tekton-robot commented Jun 30, 2022

ywluogg commented Jun 30, 2022

ywluogg commented Jun 30, 2022

Yongxuanzhang commented Jun 30, 2022

lbernick Jun 30, 2022

Choose a reason for hiding this comment

Yongxuanzhang Jun 30, 2022

Choose a reason for hiding this comment

tekton-robot commented Jun 30, 2022

tekton-robot commented Jul 4, 2022

tekton-robot commented Jul 4, 2022

ywluogg commented Jul 4, 2022

tekton-robot commented Jul 4, 2022

Yongxuanzhang commented Jul 4, 2022

ywluogg commented Jul 4, 2022

Yongxuanzhang commented Jun 10, 2022 •

edited

Loading