Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1: Add conversion for Task.Resources #5253

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Aug 2, 2022

Changes

This commit adds support for Task.Resources when converting between v1beta1 and v1
versions of Tasks. This will allow us to release v1 Task in a backwards compatible way,
by ensuring that v1beta1 Tasks with Resources will have the Resources serialized into
annotations on the v1 Task on conversion.

Part n of #4546

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • n/a Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Aug 2, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 2, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 97.4% 94.4% -2.9
pkg/apis/version/conversion.go Do not exist 0.0%

@lbernick
Copy link
Member Author

lbernick commented Aug 2, 2022

/retest

filed #5254

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 97.4% 94.4% -2.9
pkg/apis/version/conversion.go Do not exist 81.2%

@abayer
Copy link
Contributor

abayer commented Aug 8, 2022

/approve
/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@JeromeJu JeromeJu mentioned this pull request Aug 9, 2022
6 tasks
This commit adds support for Task.Resources when converting between v1beta1 and v1
versions of Tasks. This will allow us to release v1 Task in a backwards compatible way,
by ensuring that v1beta1 Tasks with Resources will have the Resources serialized into
annotations on the v1 Task on conversion.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 97.4% 94.4% -2.9
pkg/apis/version/conversion.go Do not exist 81.2%

@lbernick
Copy link
Member Author

/retest

@abayer
Copy link
Contributor

abayer commented Aug 16, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@tekton-robot tekton-robot merged commit 73f4e0d into tektoncd:main Aug 16, 2022
@JeromeJu JeromeJu mentioned this pull request Nov 21, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants