Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified test to allow for validation #5284

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

vsinghai
Copy link

@vsinghai vsinghai commented Aug 8, 2022

Changes

Prior to this commit, the previous iteration
of this test set the PipelineRun status to True,
essentially allowing the PipelineRun execute
without any validation. Furthermore, the test did
not test for the various embedded.status.

In this commit, we add implementation to test for
Pipeline Results which allow for validation to
execute by setting the PipelineRun status to Unknown.
Also, the test accounts for the different embedded.status.

Fixes bug #5283

/kind bug
/cc @jerop

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot requested a review from jerop August 8, 2022 16:52
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2022
@tekton-robot
Copy link
Collaborator

Hi @vsinghai. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 8, 2022
@dibyom
Copy link
Member

dibyom commented Aug 8, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2022
@vsinghai
Copy link
Author

vsinghai commented Aug 8, 2022

TestPipelineRunTimeout is a known flake - #3460

/test pull-tekton-pipeline-alpha-integration-tests

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this test @vsinghai!

planning to create a separate commit fixing the custom task in pipeline results with finally?

pkg/reconciler/pipelinerun/pipelinerun_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
Prior to this commit, the previous iteration
of this test set the `PipelineRun` status to `True`,
essentially allowing the `PipelineRun` execute
without any validation. Furthermore, the test did
not test for the various `embedded.status`.

In this commit, we add implementation to test for
`Pipeline` `Results` which allow for validation to
execute by setting the `PipelineRun` status to `Unknown`.
Also, the test accounts for the different `embedded.status`.

Fixes bug [tektoncd#5283](tektoncd#5283)

/kind bug
/cc @jerop
@vsinghai
Copy link
Author

/cc @dibyom

@tekton-robot tekton-robot requested a review from dibyom August 11, 2022 16:52
@abayer
Copy link
Contributor

abayer commented Aug 11, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
@tekton-robot tekton-robot merged commit bffda48 into tektoncd:main Aug 11, 2022
@vsinghai vsinghai deleted the pipelineresult branch August 11, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants