-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified test to allow for validation #5284
Conversation
Hi @vsinghai. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
TestPipelineRunTimeout is a known flake - #3460 /test pull-tekton-pipeline-alpha-integration-tests |
4cdb22d
to
c47a824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for fixing this test @vsinghai!
planning to create a separate commit fixing the custom task in pipeline results with finally?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Prior to this commit, the previous iteration of this test set the `PipelineRun` status to `True`, essentially allowing the `PipelineRun` execute without any validation. Furthermore, the test did not test for the various `embedded.status`. In this commit, we add implementation to test for `Pipeline` `Results` which allow for validation to execute by setting the `PipelineRun` status to `Unknown`. Also, the test accounts for the different `embedded.status`. Fixes bug [tektoncd#5283](tektoncd#5283) /kind bug /cc @jerop
c47a824
to
5144361
Compare
/cc @dibyom |
/lgtm |
Changes
Prior to this commit, the previous iteration
of this test set the
PipelineRun
status toTrue
,essentially allowing the
PipelineRun
executewithout any validation. Furthermore, the test did
not test for the various
embedded.status
.In this commit, we add implementation to test for
Pipeline
Results
which allow for validation toexecute by setting the
PipelineRun
status toUnknown
.Also, the test accounts for the different
embedded.status
.Fixes bug #5283
/kind bug
/cc @jerop
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes